fix(web): keep selected search filters visible - #1685
dipeshbabu wants to merge 3 commits into
Conversation
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
Included review availability: This review used your included allowance. Your plan provides up to 8 included reviews per hour; 7 remain after this review. WalkthroughThe search filter now keeps selected entries visible and places them before fuzzy matches. It sorts a copy of the filtered list. Tests cover filtering, entry ordering, click callbacks, duplicate prevention, and preservation of the input array. ChangesSelected search entries
Priority: ⬇️ Low Estimated code review effort: 2 (Simple) | ~10 minutes Change: Bug fix · Severity of issue fixed: Low Merge Risk: ⚪ Minimal · up to The change keeps selected filters visible while preserving normal filtering and click behavior. No actionable merge-blocking risk remains; merge after normal checks pass. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Fixes #131
Typing into the language or repository filter hid selected entries that did not match the filter text. Keep those selections visible at the top so users can see and clear every active filter, while filtering the remaining entries normally.
Selected entries appear only once when they also match the search. Sorting now copies the list instead of mutating the caller's entries.
Validation completed before opening this PR:
Note
Low Risk
Localized UI change to search filter panel list rendering with regression tests; no auth, API, or data-path impact.
Overview
Fixes a search sidebar bug where typing in the language or repository filter box could hide active selections that did not match the search text, making them hard to see or clear.
Filter list behavior now always pins selected entries ahead of Fuse matches on the non-selected remainder, keeps selections visible when nothing else matches, and avoids duplicate rows when a selected item also matches. Display sorting copies the filtered array before
sortso the parententriesarray is not mutated in place.Adds Vitest coverage for these cases and a changelog entry under Unreleased.
Reviewed by Cursor Bugbot for commit 0bb329b. Bugbot is set up for automated code reviews on this repo. Configure here.
Summary by cubic
Fixes #131 by keeping selected language and repository filters visible at the top while typing, so active filters can always be seen and cleared.
Written for commit 82ac4e2. Summary will update on new commits.
Summary by CodeRabbit