zstd compression and more flexible configuration#4
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds opt-in zstd compression for OTLP export requests and refactors configuration parsing to support more flexible endpoint/compression environment variable overrides.
Changes:
- Add
zstdas an exporter compression option (alongside gzip) and propagate the choice through the export pipeline. - Switch env var parsing to
envyand add support for overriding collector/exporter endpoints via additional env vars. - Update CI publishing to suffix layer/image names for non-
mainrefs.
Reviewed changes
Copilot reviewed 5 out of 6 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
src/exporter.rs |
Select gzip vs zstd encoder at export time and set Content-Encoding accordingly. |
src/env.rs |
Introduce Env deserialization via envy, add Compression, and expand endpoint configuration precedence. |
README.md |
Document new/updated configuration precedence rules. |
Cargo.toml |
Add envy dependency for env var parsing. |
Cargo.lock |
Lockfile update for envy. |
.github/workflows/ci.yaml |
Add a ref-based suffix to published layer/image names. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This reverts commit 7812dff.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds
zstdcompression support as an opt-in (for now) and makes the configuration options more flexible