Skip to content

Use POSIX-compatible conditionals in install test helper invoked via sh #779

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tammy-baylis-swi merged 2 commits into from
Jun 4, 2026
Merged

Use POSIX-compatible conditionals in install test helper invoked via sh #779

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8ef3722
Initial plan
Copilot Jun 4, 2026
eeb40d2
Fix install helper to use POSIX shell conditionals
Copilot Jun 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions tests/docker/install/_helper_run_install_tests.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,12 +17,12 @@
# stop on error
set -e

if [[ "$OSTYPE" == "darwin"* ]] || [ -n "$PYTHON_VERSION" ];
if [ "${OSTYPE#darwin}" != "$OSTYPE" ] || [ -n "$PYTHON_VERSION" ];
then
# On macOS or when PYTHON_VERSION is explicitly set, use environment variable
python_version=$PYTHON_VERSION
python_version_no_dot=$(echo "$python_version" | sed 's/\.//')
if [[ "$OSTYPE" == "darwin"* ]]; then
if [ "${OSTYPE#darwin}" != "$OSTYPE" ]; then
pretty_name="macOS $(sw_vers -productVersion)"
else
pretty_name=$(grep PRETTY_NAME /etc/os-release | sed 's/PRETTY_NAME="//' | sed 's/"//')
Expand Down
Loading