feat: recommend tgpu.slot in accessor out-of-codegen errors#2613
Merged
Conversation
1 task
|
pkg.pr.new packages benchmark commit |
📊 Bundle Size Comparison
👀 Notable resultsStatic test results:No major changes. Dynamic test results:No major changes. 📋 All resultsClick to reveal the results table (355 entries).
If you wish to run a comparison for other, slower bundlers, run the 'Tree-shake test' from the GitHub Actions menu. |
Resolution Time Benchmark---
config:
themeVariables:
xyChart:
plotColorPalette: "#E63946, #3B82F6, #059669"
---
xychart
title "Random Branching (🔴 PR | 🔵 main | 🟢 release)"
x-axis "max depth" [1, 2, 3, 4, 5, 6, 7, 8]
y-axis "time (ms)"
line [0.91, 1.71, 3.42, 6.17, 7.08, 10.87, 19.98, 22.41]
line [0.90, 1.82, 3.73, 5.42, 6.90, 8.70, 20.27, 22.42]
line [0.83, 1.76, 3.67, 5.39, 6.62, 8.91, 20.02, 23.34]
---
config:
themeVariables:
xyChart:
plotColorPalette: "#E63946, #3B82F6, #059669"
---
xychart
title "Linear Recursion (🔴 PR | 🔵 main | 🟢 release)"
x-axis "max depth" [1, 2, 3, 4, 5, 6, 7, 8]
y-axis "time (ms)"
line [0.27, 0.53, 0.66, 0.81, 1.15, 1.18, 1.39, 1.53]
line [0.28, 0.52, 0.64, 0.80, 1.08, 1.19, 1.36, 1.51]
line [0.29, 0.51, 0.67, 0.80, 1.06, 1.11, 1.38, 1.50]
---
config:
themeVariables:
xyChart:
plotColorPalette: "#E63946, #3B82F6, #059669"
---
xychart
title "Full Tree (🔴 PR | 🔵 main | 🟢 release)"
x-axis "max depth" [1, 2, 3, 4, 5, 6, 7, 8]
y-axis "time (ms)"
line [0.78, 1.90, 3.62, 5.94, 11.50, 23.84, 50.81, 103.65]
line [0.81, 1.85, 3.91, 6.22, 11.52, 23.58, 52.19, 104.48]
line [0.95, 1.97, 3.08, 6.56, 11.94, 23.51, 49.78, 104.08]
|
iwoplaza
approved these changes
Jun 15, 2026
aleksanderkatan
requested changes
Jun 15, 2026
aleksanderkatan
left a comment
aleksanderkatan
left a comment
Contributor
There was a problem hiding this comment.
At least one test where this error appears, please
Contributor
Author
|
Added two tests for the out-of-codegen error messages in
Both verify the full error message including the Task list (5/5 completed)
|
Contributor
|
Can we see somewhere who is responsible for requesting pullfrog PRs? I'd like to avoid potential situations where somebody requests a PR and merges it with only a self-approve, since this basically skips code review |
Collaborator
All convo with pullfrog happens on GitHub, in this case this PR was requested by me via the connected issue. |
aleksanderkatan
approved these changes
Jun 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates the error messages for
tgpu.accessor.$andtgpu.mutableAccessor.$when accessed outside of codegen mode, to recommend usingtgpu.slotfor non-WGSL values instead.Closes #2611.
DeepSeek Pro(free via Pullfrog for OSS) ｜ 𝕏