Skip to content

ci: send regression notifications if tests for code coverage error#1496

Open
zimeg wants to merge 1 commit intomainfrom
zimeg-ci-test-coverage-regressions
Open

ci: send regression notifications if tests for code coverage error#1496
zimeg wants to merge 1 commit intomainfrom
zimeg-ci-test-coverage-regressions

Conversation

@zimeg
Copy link
Copy Markdown
Member

@zimeg zimeg commented May 11, 2026

Summary

This PR adds the "codecov" job to lists of what regression notifications are sent for 📣

Testing

Let's hope to not find out! But earlier workflows erroring appear as:

regressions

🔗 https://github.com/slackapi/bolt-python/actions/runs/25383886159/job/74439411695

Category

  • Others

Notes

  • If this was intentional because of test duplication I wasn't sure, but I found the "x" on main to be confusing without having seen a notification in channel 🙏 ✨

Requirements

Please read the Contributing guidelines and Code of Conduct before creating this issue or pull request. By submitting, you are agreeing to those rules.

  • I've read and understood the Contributing Guidelines and have done my best effort to follow them.
  • I've read and agree to the Code of Conduct.
  • I've run ./scripts/install_all_and_run_tests.sh after making the changes.

@zimeg zimeg self-assigned this May 11, 2026
@zimeg zimeg requested a review from a team as a code owner May 11, 2026 01:29
@zimeg zimeg added enhancement New feature or request github_actions Pull requests that update GitHub Actions code semver:patch labels May 11, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented May 11, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91.32%. Comparing base (ae0ba57) to head (56a78ba).
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1496   +/-   ##
=======================================
  Coverage   91.32%   91.32%           
=======================================
  Files         228      228           
  Lines        7262     7262           
=======================================
  Hits         6632     6632           
  Misses        630      630           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Copy Markdown
Contributor

@WilliamBergamin WilliamBergamin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure we should merge this 🤔

From what I understand the regression notification aren't depended on the codecov uploading, if the tests fail in the codecov that means there is some flakiness in our unittests, but I don't think we want to get notified when there is CodeCov infrastructure issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request github_actions Pull requests that update GitHub Actions code semver:patch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants