feat: take pipeline's estimator into account to decide tabular vectorizer options in TabularPipeline - #2152
Merged
lisaleemcb merged 17 commits intoSep 15, 2026
Conversation
GaelVaroquaux
previously requested changes
Jun 10, 2026
MarieSacksick
added
the
CFM sprint June 2026
MarieSacksick
requested changes
Jun 10, 2026
Contributor
|
Can you add the link to this issue that will be closed by this PR please? |
correcting doc Co-authored-by: Marie Sacksick <79304610+MarieSacksick@users.noreply.github.com>
Co-authored-by: Marie Sacksick <79304610+MarieSacksick@users.noreply.github.com>
MarieSacksick
changed the title
MarieSacksick
changed the title
Co-authored-by: Marie Sacksick <79304610+MarieSacksick@users.noreply.github.com>
MarieSacksick
approved these changes
Jun 10, 2026
MarieSacksick
left a comment
MarieSacksick
left a comment
Contributor
There was a problem hiding this comment.
Good for me, thanks :)!
and congratulations!!
waiting for someone else review.
jeromedockes
left a comment
jeromedockes
left a comment
Member
There was a problem hiding this comment.
thank you very much @khaoulariad ! just a few comments :)
Member
|
Hi @khaoulariad, this PR hasn't seen any action in a long time. Are you still interested in working on this? |
… into pr/khaoulariad/2152
rcap107
reviewed
Sep 15, 2026
rcap107
left a comment
rcap107
left a comment
Member
There was a problem hiding this comment.
The PR is almost done 🎉 , the conflict is caused by the documentation move.
The entry about this PR in the changelog is in the wrong location: it should be moved to the ongoing development section.
After that's done, we can merge.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug Fix Pull Request
Description
Addresses #1967
Checklist
How Has This Been Tested?
AI Disclosure