Feature/generic view modifiers - #270
Open
gurmeherchawla wants to merge 2 commits into
Open
Conversation
…sedPeerSwift(for: variableDeclarations: functionDeclarations: stateVariables: visibility:)` in SkipSyntax/Kotlin/KotlinBridgeToKotlinVisitor.swift
…e generation in Tests/
Member
|
This could be a very useful feature! FTR, the CI failure is due to the test case needing to be updated, but it looks like something broke with the spacing (e.g. The diff is: 37a38
> typeErased.body = { [unowned typeErased] in (typeErased.genericvalue as! Self).body($0) }
43,44c44
< init(_ value: Any) {
< self.genericvalue = value
---
> init(_ value: Any) {self.genericvalue = value
73c73
< returnAnyBridging.toJavaObject(f_return_swift, options: [])!
---
> return AnyBridging.toJavaObject(f_return_swift, options: [])! |
Author
|
Thank you! I've verified the code but the whitespaces seem okay. In full disclosure, the test case was written by AI and if that's the root case, it reinstates my faith in LLMs. PS I have a PR open for a custom font issue in SkipUI as well. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add support for code generation of generic View Modifiers in typeErasedPeerSwift(for: variableDeclarations: functionDeclarations: stateVariables: visibility:) in SkipSyntax/Kotlin/KotlinBridgeToKotlinVisitor.swift
Add Test Case for Generic View Modifier via testGenericCustomModifier() in Tests
REQUIRED: I have signed the Contributor Agreement
REQUIRED: I have tested my change locally with
swift testOPTIONAL: I have tested my change on an iOS simulator or device
OPTIONAL: I have tested my change on an Android emulator or device
](https://github.com/Clockworks-Solutions/skipstone.git)