Bugfix: Only Dismiss Keyboard on User Scroll - #482
Open
fhasse95 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While testing a form with
scrollDismissesKeyboardenabled, I noticed that the keyboard could be dismissed when the scroll was triggered programmatically. This can happen for example in cases where a focusedTextFieldis scrolled into view using aScrollViewProxy.Example:
Before:

After:

This PR fixes the issue by making keyboard dismissal only react to actual user scroll gestures. Programmatic scroll updates can still move content into view, while manually scrolling the view continues to dismiss the keyboard as expected.
Update:
You can also reproduce this bug using the
KeyboardScrollDismissPlaygroundin the Showcase app by, for example, positioning the TextField at the top of the List so that it isn't fully within the view, causing it to scroll into view automatically. You'll then see that it is dismissed immediately, even though the user hasn't actively scrolled.Before:

After:

Thank you for contributing to the Skip project! Please review the contribution guide at https://skip.dev/docs/contributing/ for advice and guidance on making high-quality PRs.
Use this space to describe your change and add any labels (bug, enhancement, documentation, etc.) to help categorize your contribution.
Skip Pull Request Checklist:
swift test