Added getMeanLength function. Description and tests needed. - #44
Closed
henryhansen wants to merge 1 commit into
Closed
Added getMeanLength function. Description and tests needed.#44henryhansen wants to merge 1 commit into
henryhansen wants to merge 1 commit into
Conversation
Member
|
@henryhansen Sorry that I ignored this pull request for so long. I think I was still waiting for the description and tests to arrive. Anyways, to get the mean length you can not just calculate the mean weight and then convert that to a length. You have to convert to lengths first and then take the mean. I'll close this pull request but I opened another one straight against core mizer, to be included in the next release, see sizespectrum/mizer#576 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.