Update species_params<- to diff changes and protect them#457
Merged
Conversation
…rameters. Removed unnecessary print method for `given_species_params`.
…_species_params()`
…ssue where it was bypassed by given_species_params. Update documentation to reflect new behaviour.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, modifying species parameters via
species_params<-bypassedgiven_species_params. This pull request updatesspecies_params<-to automatically detect changes and record them ingiven_species_params, protecting them from being overwritten by defaults and automatically triggering recalculations of dependent arrays. This restores expected behaviour and aligns it withgiven_species_params<-but with a silent footprint for scripting.Also updates the vignettes, cheatsheets, and Roxygen docs to reflect these changes, explicitly differentiating the interactive utility of
given_species_params<-from the silent diffing behaviour ofspecies_params<-.