[Warlock] Add Unstable Affliction stack remains expression - #11643
Merged
nyterage merged 1 commit intoJul 29, 2026
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unstable Affliction (UA) applications have independent 8-second-duration application stacks, and the module has special handling to manage the correct decrement of those stacks. While the existing
dot.unstable_affliction.stackexpression returns the current number of stacks anddot.unstable_affliction.remainsreturns the time until the complete DoT expires, there was no way for the APL to determine when individual stacks would expire or when the target would fall below a specific number of stacks.This PR adds the following target-specific expressions:
dot.unstable_affliction.stack_remains.N: Returns the time remaining before the target falls belowNUnstable Affliction stacks, or0if the target already has fewer thanNstacks.dot.unstable_affliction.stack_remains.current: Returns the time remaining before the target loses its next UA stack, or0if UA is not active.For example, with 5 active UA stacks:
dot.unstable_affliction.stack_remains.5returns the time until the first stack expires and the target drops to 4 stacks.dot.unstable_affliction.stack_remains.3returns the time until the third stack expires and the target drops below 3 stacks.dot.unstable_affliction.stack_remains.1returns the time until the final stack expires.dot.unstable_affliction.stack_remains.currentis equivalent todot.unstable_affliction.stack_remains.5in this case and always returns the time until the next stack expires.The numeric argument must be a positive integer no greater than
99, the current maximum number of Unstable Affliction stacks.To support these expressions, the independent stack expiration events are now tracked per target. These events are stored in application order, which is also their expiration order because every Unstable Affliction application has the same duration. Each event is removed from the tracking list when it executes, and the list is cleared when the Unstable Affliction DoT expires, is canceled, or the target data is reset.
Stack expiration events invalidated by a previous Unstable Affliction expiration or cancellation are ignored. This prevents an old event from decrementing the stacks of a later Unstable Affliction application on the same target.
The expressions use the action's current expression target, allowing them to work correctly with target-specific APL behavior such as
target_ifandcycle_targets.