Allow build_options to be specified as a base64 string#330
Merged
Conversation
ddaspit
approved these changes
Jul 6, 2026
ddaspit
left a comment
ddaspit
left a comment
Contributor
There was a problem hiding this comment.
@ddaspit reviewed 1 file and all commit messages, and made 1 comment.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on Enkidu93).
Enkidu93
approved these changes
Jul 7, 2026
Enkidu93
left a comment
Enkidu93
left a comment
Collaborator
There was a problem hiding this comment.
@Enkidu93 reviewed 1 file and all commit messages, and made 1 comment.
Reviewable status:
pmachapman
force-pushed
the
build_options_base64
branch
from
July 20, 2026 17:52
21df935 to
947af36
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #330 +/- ##
=======================================
Coverage 92.08% 92.08%
=======================================
Files 382 382
Lines 24170 24170
=======================================
Hits 22257 22257
Misses 1913 1913 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Partial fix for: sillsdev/serval#966.
Required for: sillsdev/serval#992
This change is