Fix ImageCropper skipping downscale for tall images#1531
Merged
Conversation
The pre-crop downscale threshold checked Image.Width twice instead of checking Width and Height, so a tall image (height > 1000, width <= 1000) was never downscaled before cropping. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Contributor
imnasnainaec
marked this pull request as ready for review
July 13, 2026 18:03
jasonleenaylor
approved these changes
Jul 15, 2026
jasonleenaylor
left a comment
jasonleenaylor
left a comment
Contributor
There was a problem hiding this comment.
@jasonleenaylor reviewed 3 files and all commit messages, and made 1 comment.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on imnasnainaec).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The pre-crop downscale threshold checked
Image.Widthtwice instead of checkingWidthandHeight, so a tall image (height > 1000, width <= 1000) was never downscaled before cropping.Devin review: https://app.devin.ai/review/sillsdev/libpalaso/pull/1531
This change is