Skip to content

Redesign FwLite comments panel with responsive layout - #2470

Open
hahn-kev-bot wants to merge 6 commits into
developfrom
comment-updates
Open

Redesign FwLite comments panel with responsive layout#2470
hahn-kev-bot wants to merge 6 commits into
developfrom
comment-updates

Conversation

@hahn-kev-bot

@hahn-kev-bot hahn-kev-bot commented Jul 23, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • Refactored CommentDialog.svelte into a modular entry-editor/comments/ component tree (CommentPanel, CommentThread, CommentItem, CommentReplyInput, CommentAuthorAvatar, CommentDialog)
  • Redesigned the comments panel with a responsive docked layout: full sidebar on large screens, snap-point drawer on mobile/tablet
  • Added is-extra-large.svelte.ts breakpoint hook and two new CSS breakpoints to drive the responsive layout

Screenshots

thread list (desktop)
browser-screenshot-localhost-mrx6y7i4

thread list (tablet)
browser-screenshot-localhost-mrx6ykux

thread list (mobile)
browser-screenshot-localhost-mrx6yqfu

thread open at default drawer stop
browser-screenshot-localhost-mrx6yx62

max drawer stop
browser-screenshot-localhost-mrx6z01g

minimum drawer stop
browser-screenshot-localhost-mrx6z615

start new thread (mobile)
browser-screenshot-localhost-mrx6zkup

start new thread (desktop)
browser-screenshot-localhost-mrx6zpvu

hahn-kev and others added 4 commits July 22, 2026 14:47
Split the monolithic dialog into focused components and keep reply/edit draft text local to avoid Svelte bind errors on new threads.

Co-authored-by: Cursor <cursoragent@cursor.com>
Collapse/expand threads, resolve controls, and mobile thread detail with always-visible reply inputs adapted per breakpoint.

Co-authored-by: Cursor <cursoragent@cursor.com>
Keep the entry scrollable behind a non-modal drawer, open threads in full detail below xl, work around vaul-svelte's Svelte 5 activeSnapPoint bug, and keep the reply input pinned to the visible drawer bottom.

Co-authored-by: Cursor <cursoragent@cursor.com>
- Adds ds-bundle with token + visual-reference system (not a React bundle)
- HTML preview cards for core primitives: button, badge, input, label, textarea, alert, card, multi-ws-field, app-shell, master-detail, typography, colors
- .design-sync/ config explaining the off-script Svelte approach
- Compiled Tailwind CSS and design token imports via styles.css
@github-actions github-actions Bot added the 💻 FW Lite issues related to the fw lite application, not miniLcm or crdt related label Jul 23, 2026
@coderabbitai

coderabbitai Bot commented Jul 23, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

Warning

Review limit reached

@hahn-kev, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 57 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: e7023425-228a-4aeb-bea6-0c3cedcf4b1c

📥 Commits

Reviewing files that changed from the base of the PR and between 39970cb and f0c8e72.

📒 Files selected for processing (22)
  • frontend/viewer/src/css-breakpoints.ts
  • frontend/viewer/src/lib/components/ui/drawer/drawer-nested.svelte
  • frontend/viewer/src/lib/components/ui/drawer/drawer.svelte
  • frontend/viewer/src/lib/entry-editor/CommentDialog.svelte
  • frontend/viewer/src/lib/entry-editor/comments/CommentAuthorAvatar.svelte
  • frontend/viewer/src/lib/entry-editor/comments/CommentDialog.svelte
  • frontend/viewer/src/lib/entry-editor/comments/CommentItem.svelte
  • frontend/viewer/src/lib/entry-editor/comments/CommentPanel.svelte
  • frontend/viewer/src/lib/entry-editor/comments/CommentReplyInput.svelte
  • frontend/viewer/src/lib/entry-editor/comments/CommentThread.svelte
  • frontend/viewer/src/lib/entry-editor/comments/comment-author.ts
  • frontend/viewer/src/lib/entry-editor/comments/types.ts
  • frontend/viewer/src/lib/hooks/is-extra-large.svelte.ts
  • frontend/viewer/src/locales/en.po
  • frontend/viewer/src/locales/es.po
  • frontend/viewer/src/locales/fr.po
  • frontend/viewer/src/locales/id.po
  • frontend/viewer/src/locales/ko.po
  • frontend/viewer/src/locales/ms.po
  • frontend/viewer/src/locales/sw.po
  • frontend/viewer/src/locales/vi.po
  • frontend/viewer/src/project/browse/EntryView.svelte
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch comment-updates

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

- Disable vaul's default handle (it was hidden under the absolute panel)
- Render a custom handle div inside the panel instead
@myieye

myieye commented Jul 23, 2026

Copy link
Copy Markdown
Collaborator

It's interesting that new comments and replies have such different buttons 🤔

@hahn-kev hahn-kev changed the title Redesign FwLite comments panel with responsive layout and refactor history service Redesign FwLite comments panel with responsive layout Jul 23, 2026
@hahn-kev

Copy link
Copy Markdown
Collaborator

Yeah, I found that semi consistent between other apps interestingly enough.

@myieye

myieye commented Jul 23, 2026

Copy link
Copy Markdown
Collaborator

This is looking very good!

But, I do have a bunch of UX thoughts:

  • The new comment area looks kind of disabled. There's probably a better way to make it distinct than giving it such a gray background
image
  • Clicking "+ Add" should focus the text-area (both if the text-area is not yet visible AND if it is already visible)
  • "+ Add" is the only "add button" we have that isn't "+ <thing>". Maybe it should be "+ Comment".
  • Use "+ Add" to start a thread should probably just be replaced with a button that does what it's suggesting e.g. a "+ Comment" button
image
  • Edge case (?): Use "+ Add" to start a thread is shown even when commenting is not allowed (i.e. there's no "+ Add" button. I saw this on a local only project. But maybe it applied to the viewer role too?
  • Actually after using the dev-only read-only permission toggle the commenting UI seems unchanged. So, it probably needs to respect the user's role.
  • The Resolve and Unresolve buttons should probably have tooltips (preferably the fancy shadcn ones not just a title attribute)
  • On mobile there's the icon resolve-button in the list and a labeled resolve button when a single comment is open. Nice. Should the user be taken back to the list when they click that resolve button? Should comments become un-editable on a resolved thread? (just UI enforced?) It turns out that GDocs does this, but only for the initial comment in a thread 😆!
  • Do we track a timestamp for "Comment edited"? Probably not. Saving and exposing that would be a baby step towards transparency. E.g.
    • User one writes "This is my favorite word in the dictionary"
    • User two writes "Yes mine too"
    • User one edits their comment to "My elbow is shaped like a pineapple" 🍍🙃
    • User three thinks "You both have pineapple-shaped elbows?!"
  • I'd like the "add new comment" area to be decorated with my initials avatar and/or name. It's just nice to know who I'm posting as before hand 🤔. It would also make it more obvious that we have a weird bug. The UI thinks I'm Test Admin while the backend knows I'm Tim Haasdyk...Claude is currently investigating.
  • I'd love to see an indicator on the comment icon-button if there are unresolved comments

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

💻 FW Lite issues related to the fw lite application, not miniLcm or crdt related

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants