Add Android foreground work queue for long-running work - #2445
Draft
hahn-kev-bot wants to merge 5 commits into
Draft
Add Android foreground work queue for long-running work#2445hahn-kev-bot wants to merge 5 commits into
hahn-kev-bot wants to merge 5 commits into
Conversation
Co-authored-by: Cursor <cursoragent@cursor.com>
Keep the Android work-queue wiring and take develop's stronger project-delete path (#2392). Also drain the work host while still holding the queue lock so StopService cannot race the next StartForegroundService. Co-authored-by: Cursor <cursoragent@cursor.com>
Publish a general user-notification event when Android foreground protection fails to start, keeping downloads fail-open while surfacing a copyable error toast. Add a monochrome notification icon for the foreground service. Co-authored-by: Cursor <cursoragent@cursor.com>
Contributor
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
github-actions
Bot
added
the
💻 FW Lite
|
The latest updates on your projects. Learn more about Argos notifications ↗︎
|
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan
Important
I added a new event
UserNotificationwhich let's the backend publish notifications (in this case about an error), however those messages won't be translated (only happens in the frontend), should we change how this works? or just leave it as an escape hatch but avoid using it most of time?