Defer non-critical FW Lite work off project first load - #2443
Draft
hahn-kev-bot wants to merge 1 commit into
Draft
Defer non-critical FW Lite work off project first load#2443hahn-kev-bot wants to merge 1 commit into
hahn-kev-bot wants to merge 1 commit into
Conversation
Skip GetCanShare, GetCustomViews, and AppLastUrl GET until needed, idle-defer AppUpdate LastEvent, and omit unused writing-system exemplars from GetWritingSystems. Co-authored-by: Cursor <cursoragent@cursor.com>
Contributor
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
The latest updates on your projects. Learn more about Argos notifications ↗︎
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
GetCanShareuntil Troubleshoot opens, and deferGetCustomViewsuntil the view picker / manage dialog (or a restored custom view selection).AppLastUrlpreference GET, and idle-deferAppUpdateLastEventreplay so they stay off the critical path.GetWritingSystemsto shrink the project-open JSInterop payload.Test plan
/project/example-project/browseand confirm console no longer logsGetCanShare,GetCustomViews, orPreferencesService.Get(AppLastUrl)on first loadGetWritingSystemsreturns emptyexemplarsarrayscanShareis trueKevin:
Note
I'm not really tied to any of these, but in attempts to speed up first run I thought I'd try this out and see which ones are worth keeping.