Skip to content

Defer non-critical FW Lite work off project first load - #2443

Draft
hahn-kev-bot wants to merge 1 commit into
developfrom
defer-fwlite-first-load-work
Draft

Defer non-critical FW Lite work off project first load#2443
hahn-kev-bot wants to merge 1 commit into
developfrom
defer-fwlite-first-load-work

Conversation

@hahn-kev-bot

@hahn-kev-bot hahn-kev-bot commented Jul 15, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • Gate GetCanShare until Troubleshoot opens, and defer GetCustomViews until the view picker / manage dialog (or a restored custom view selection).
  • Skip the unused frontend AppLastUrl preference GET, and idle-defer AppUpdate LastEvent replay so they stay off the critical path.
  • Omit unused writing-system exemplars from GetWritingSystems to shrink the project-open JSInterop payload.

Test plan

  • Open /project/example-project/browse and confirm console no longer logs GetCanShare, GetCustomViews, or PreferencesService.Get(AppLastUrl) on first load
  • Confirm GetWritingSystems returns empty exemplars arrays
  • Open Troubleshoot and verify Share buttons still appear when canShare is true
  • Open the view picker / manage custom views and confirm custom views still load
  • With a custom view selected as the preferred view, reload and confirm it restores after custom views load

Kevin:

Note

I'm not really tied to any of these, but in attempts to speed up first run I thought I'd try this out and see which ones are worth keeping.

Skip GetCanShare, GetCustomViews, and AppLastUrl GET until needed, idle-defer AppUpdate LastEvent, and omit unused writing-system exemplars from GetWritingSystems.

Co-authored-by: Cursor <cursoragent@cursor.com>
@coderabbitai

coderabbitai Bot commented Jul 15, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 00b94fa4-a65a-429a-9dea-deefc0db1469

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch defer-fwlite-first-load-work

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions github-actions Bot added the 💻 FW Lite issues related to the fw lite application, not miniLcm or crdt related label Jul 15, 2026
@argos-ci

argos-ci Bot commented Jul 15, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Argos notifications ↗︎

Build Status Details Updated (UTC)
default (Inspect) ✅ No changes detected - Jul 15, 2026, 9:31 AM
e2e (Inspect) ⚠️ Changes detected (Review) 5 changed Jul 15, 2026, 9:38 AM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

💻 FW Lite issues related to the fw lite application, not miniLcm or crdt related

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants