improve layout of edit reference dialog#435
Open
nabalone wants to merge 3 commits into
Open
Conversation
This reverts commit 630c248.
Refine the Mark Verses edit reference dropdown layout: place the verse suffix next to the verse and let the native select size to its content (auto width) instead of a fixed min-width with extra right padding. This tightens the dropdown spacing in the mobile Mark Verses edit reference UI. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Tighten the edit reference dialog by reducing the flex-row gap from 2 to 0.5, decreasing the space on either side of the dash separating the start and end verse references. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Collaborator
Author
|
Looks funny in the corner corner case that you are on an iphone SE correcting an ill-formed verse reference which had been entered on desktop and the reference has triple digit numbers, like in the Psalms. And even then I think it is still straightforwardly usable. |
Collaborator
Author
|
Oh also slightly funny in the same corner corner case (on an iphone SE correcting an ill-formed verse reference which had been entered on desktop) if the passage spans multiple chapters in the 2-digits 
|
Collaborator
Author
|
@josephmyers I am seeing this rounded-corner menu instead of the wheel as my native select everywhere on my iphone. This person claims the wheel has been largely retired https://stackoverflow.com/a/74461785 But you can see that we are using the native select on the phone 
|
nabalone
marked this pull request as ready for review
July 17, 2026 13:08
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Layout improvements for the Mark Verses edit reference dropdown (
EditReferenceDropdown.tsx, mobile view):width: 'auto') instead of a fixedminWidth: 56with extra right padding (pr: 2.5), tightening the dropdown spacing.No functional/behavior change — purely visual layout of the edit reference UI.
Test plan
🤖 Generated with Claude Code