Skip to content

po: tell xgettext that we want line numbers#1653

Open
hallyn wants to merge 1 commit into
shadow-maint:masterfrom
hallyn:2026-06-21/xlations
Open

po: tell xgettext that we want line numbers#1653
hallyn wants to merge 1 commit into
shadow-maint:masterfrom
hallyn:2026-06-21/xlations

Conversation

@hallyn

@hallyn hallyn commented Jun 22, 2026

Copy link
Copy Markdown
Member

This helps translators find the origin of each entry.

On the other hand, in man/po/ tell msgmerge not to add file:line.

This helps translators find the origin of each entry.

On the other hand, in man/po/ tell msgmerge not to add
file:line.

Signed-off-by: Serge Hallyn <serge@hallyn.com>
@hallyn hallyn requested a review from alejandro-colomar June 22, 2026 12:55
@hallyn

hallyn commented Jun 22, 2026

Copy link
Copy Markdown
Member Author

Hey @alejandro-colomar , this appears to do what we want for translations.
If you don't see anything obviously wrong, I'll go ahead and push it and
push an rc2.

@alejandro-colomar alejandro-colomar left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Acked-by: Alejandro Colomar <alx@kernel.org>

BTW, please also take #1650 for -rc2, which was reported by the translator.

Comment thread man/po/Makefile.in
files="$$files $$outbase"; \
done; \
cd $$tmpdir; itstool -d -o $(DOMAIN).po $$files; \
cd $$tmpdir; itstool -d $$files | msgattrib --no-location -o $(DOMAIN).po; \

@alejandro-colomar alejandro-colomar Jun 22, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know what that msgattrib is, but I trust you; feel free to merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants