lib/: Add ispfchar_c() and strisldh_rfc1035_c(), and use them instead of their pattern by alejandro-colomar · Pull Request #1469 · shadow-maint/shadow

alejandro-colomar · 2026-01-01T00:40:07Z

Queued after Add C-locale variants of isascii(3) APIs, and use them #1471.

Revisions:

v2

Move ispfchar() under lib/string/.
Document it in lib/string/README.

$ git rd 
1:  247466ab6 ! 1:  85d3d8cb4 lib/ctype/: ispfchar(): Add function
    @@ Metadata
     Author: Alejandro Colomar <alx@kernel.org>
     
      ## Commit message ##
    -    lib/ctype/: ispfchar(): Add function
    +    lib/string/ctype/isascii/: ispfchar(): Add function
     
         This function returns true if the input character is a character from
         the POSIX portable filename character set.
    @@ Commit message
     
      ## lib/Makefile.am ##
     @@ lib/Makefile.am: libshadow_la_SOURCES = \
    -   console.c \
    -   copydir.c \
    -   csrand.c \
    -+  ctype/ispfchar.c \
    -+  ctype/ispfchar.h \
    -   defines.h \
    -   encrypt.c \
    -   env.c \
    +   spawn.c \
    +   sssd.c \
    +   sssd.h \
    ++  string/ctype/isascii/ispfchar.c \
    ++  string/ctype/isascii/ispfchar.h \
    +   string/ctype/strchrisascii/strchriscntrl.c \
    +   string/ctype/strchrisascii/strchriscntrl.h \
    +   string/ctype/strisascii/strisdigit.c \
     
    - ## lib/ctype/ispfchar.c (new) ##
    + ## lib/string/README ##
    +@@ lib/string/README: Specific guidelines:
    + 
    + ctype/ - Character classification and conversion functions
    + 
    ++    isascii/
    ++  The functions defined under this directory
    ++  return true
    ++  is the character
    ++  belongs to the category specified in the function name.
    ++
    +     strchrisascii/
    +   The functions defined under this directory
    +   return true
    +
    + ## lib/string/ctype/isascii/ispfchar.c (new) ##
     @@
    -+// SPDX-FileCopyrightText: 2024, Alejandro Colomar <alx@kernel.org>
    ++// SPDX-FileCopyrightText: 2024-2025, Alejandro Colomar <alx@kernel.org>
     +// SPDX-License-Identifier: BSD-3-Clause
     +
     +
     +#include <config.h>
     +
    -+#include "ctype/ispfchar.h"
    ++#include "string/ctype/isascii/ispfchar.h"
     +
     +#include <stdbool.h>
     +
     +
     +extern inline bool ispfchar(unsigned char c);
     
    - ## lib/ctype/ispfchar.h (new) ##
    + ## lib/string/ctype/isascii/ispfchar.h (new) ##
     @@
    -+// SPDX-FileCopyrightText: 2024, Alejandro Colomar <alx@kernel.org>
    ++// SPDX-FileCopyrightText: 2024-2025, Alejandro Colomar <alx@kernel.org>
     +// SPDX-License-Identifier: BSD-3-Clause
     +
     +
    -+#ifndef SHADOW_INCLUDE_LIB_CTYPE_ISPFCHAR_H_
    -+#define SHADOW_INCLUDE_LIB_CTYPE_ISPFCHAR_H_
    ++#ifndef SHADOW_INCLUDE_LIB_STRING_CTYPE_ISASCII_ISPFCHAR_H_
    ++#define SHADOW_INCLUDE_LIB_STRING_CTYPE_ISASCII_ISPFCHAR_H_
     +
     +
     +#include <config.h>
2:  219955397 = 2:  1b917a73d lib/chkname.c: is_valid_name(): Use isalnum(3) instead of its pattern
3:  92332a203 = 3:  e2d77042a lib/chkname.c: is_valid_name(): Split Samba check
4:  1ead5c62f ! 4:  8fd9e48f6 lib/chkname.c: is_valid_name(): Use ispfchar() to simplify
    @@ lib/chkname.c
      
      #include "defines.h"
      #include "chkname.h"
    -+#include "ctype/ispfchar.h"
    ++#include "string/ctype/isascii/ispfchar.h"
      #include "string/ctype/strchrisascii/strchriscntrl.h"
      #include "string/ctype/strisascii/strisdigit.h"
      #include "string/strcmp/streq.h"

v2b

tfix

$ git rd 
1:  85d3d8cb4 ! 1:  d339ea77e lib/string/ctype/isascii/: ispfchar(): Add function
    @@ lib/string/README: Specific guidelines:
     +    isascii/
     +  The functions defined under this directory
     +  return true
    -+  is the character
    ++  if the character
     +  belongs to the category specified in the function name.
     +
          strchrisascii/
2:  1b917a73d = 2:  7f83c18fe lib/chkname.c: is_valid_name(): Use isalnum(3) instead of its pattern
3:  e2d77042a = 3:  4c7cee7bc lib/chkname.c: is_valid_name(): Split Samba check
4:  8fd9e48f6 = 4:  d39008cae lib/chkname.c: is_valid_name(): Use ispfchar() to simplify

v3

Rebase after Add C-locale variants of isascii(3) APIs, and use them #1471.

$ git range-diff master..gh/chkname gh/isascii_c..chkname 
1:  d339ea77e < -:  --------- lib/string/ctype/isascii/: ispfchar(): Add function
-:  --------- > 1:  02df1aa64 lib/string/ctype/isascii.h: ispfchar_c(): Add function
2:  7f83c18fe = 2:  4259b5bba lib/chkname.c: is_valid_name(): Use isalnum(3) instead of its pattern
3:  4c7cee7bc = 3:  69076fb30 lib/chkname.c: is_valid_name(): Split Samba check
4:  d39008cae ! 4:  1cabaf3f8 lib/chkname.c: is_valid_name(): Use ispfchar() to simplify
    @@ Metadata
     Author: Alejandro Colomar <alx@kernel.org>
     
      ## Commit message ##
    -    lib/chkname.c: is_valid_name(): Use ispfchar() to simplify
    +    lib/chkname.c: is_valid_name(): Use ispfchar_c() to simplify
     
         In the first case, we can do the transformation because a few lines
         above, we explicitly reject a name starting with a '-'.
     
    -    In the second case, we're obviously using ispfchar() instead of its
    +    In the second case, we're obviously using ispfchar_c() instead of its
         pattern.
     
         Signed-off-by: Alejandro Colomar <alx@kernel.org>
    @@ lib/chkname.c
      
      #include "defines.h"
      #include "chkname.h"
    -+#include "string/ctype/isascii/ispfchar.h"
    - #include "string/ctype/strchrisascii/strchriscntrl.h"
    - #include "string/ctype/strisascii/strisdigit.h"
    ++#include "string/ctype/isascii.h"
    + #include "string/ctype/strchrisascii.h"
    + #include "string/ctype/strisascii.h"
      #include "string/strcmp/streq.h"
     @@ lib/chkname.c: is_valid_name(const char *name)
         * sake of Samba 3.x "add machine script"
    @@ lib/chkname.c: is_valid_name(const char *name)
     -        *name == '_' ||
     -        *name == '.'))
     -  {
    -+  if (!ispfchar(*name)) {
    ++  if (!ispfchar_c(*name)) {
                errno = EILSEQ;
                return false;
        }
    @@ lib/chkname.c: is_valid_name(const char *name)
     -                *name == '-'
     -               ))
     -          {
    -+          if (!ispfchar(*name)) {
    ++          if (!ispfchar_c(*name)) {
                        errno = EILSEQ;
                        return false;
                }

v3b

Rebase

$ git range-diff 02df1aa649b7^..gh/chkname isascii_c..chkname 
1:  02df1aa64 = 1:  04d41a43c lib/string/ctype/isascii.h: ispfchar_c(): Add function
2:  4259b5bba = 2:  f15392da0 lib/chkname.c: is_valid_name(): Use isalnum(3) instead of its pattern
3:  69076fb30 = 3:  ecccb9861 lib/chkname.c: is_valid_name(): Split Samba check
4:  1cabaf3f8 = 4:  e371b465b lib/chkname.c: is_valid_name(): Use ispfchar_c() to simplify

v3c

Fix typo.

$ git range-diff gh/isascii_c gh/chkname chkname 
1:  04d41a43c ! 1:  d9c21d8e5 lib/string/ctype/isascii.h: ispfchar_c(): Add function
    @@ lib/string/ctype/isascii.h
      #define CTYPE_PRINT_C   CTYPE_GRAPH_C " "
      #define CTYPE_XDIGIT_C  CTYPE_DIGIT_C "abcdefABCDEF"
      #define CTYPE_ASCII_C   CTYPE_PRINT_C CTYPE_CNTRL_C /*NUL*/
    -+#define CTYPE_PFCHAR_C  CTYPE_ALNUM "._-"  // portable filename character set
    ++#define CTYPE_PFCHAR_C  CTYPE_ALNUM_C "._-"  // portable filename character set
      
      
      // isascii_c - is [:ascii:] C-locale
2:  f15392da0 = 2:  44af79d71 lib/chkname.c: is_valid_name(): Use isalnum(3) instead of its pattern
3:  ecccb9861 = 3:  ea9364860 lib/chkname.c: is_valid_name(): Split Samba check
4:  e371b465b = 4:  000c8c170 lib/chkname.c: is_valid_name(): Use ispfchar_c() to simplify

v3d

Rebase

$ git range-diff gh/isascii_c..gh/chkname isascii_c..chkname 
1:  d9c21d8e5e4c = 1:  31e007269215 lib/string/ctype/isascii.h: ispfchar_c(): Add function
2:  44af79d71b98 = 2:  f22a677577ec lib/chkname.c: is_valid_name(): Use isalnum(3) instead of its pattern
3:  ea9364860219 = 3:  5038f83258cb lib/chkname.c: is_valid_name(): Split Samba check
4:  000c8c170d17 = 4:  ed15a3cc0786 lib/chkname.c: is_valid_name(): Use ispfchar_c() to simplify

v3e

Rebase

$ git range-diff gh/isascii_c..gh/chkname isascii_c..chkname 
1:  31e00726 = 1:  52ecb2ee lib/string/ctype/isascii.h: ispfchar_c(): Add function
2:  f22a6775 = 2:  f8883e1b lib/chkname.c: is_valid_name(): Use isalnum(3) instead of its pattern
3:  5038f832 = 3:  8c2b031d lib/chkname.c: is_valid_name(): Split Samba check
4:  ed15a3cc = 4:  42b2e85b lib/chkname.c: is_valid_name(): Use ispfchar_c() to simplify

v3f

Rebase

$ git range-diff gh/isascii_c..gh/chkname isascii_c..chkname 
1:  52ecb2ee = 1:  e29f3481 lib/string/ctype/isascii.h: ispfchar_c(): Add function
2:  f8883e1b = 2:  4c8ed46a lib/chkname.c: is_valid_name(): Use isalnum(3) instead of its pattern
3:  8c2b031d = 3:  831be018 lib/chkname.c: is_valid_name(): Split Samba check
4:  42b2e85b = 4:  d3f1d69e lib/chkname.c: is_valid_name(): Use ispfchar_c() to simplify

v4

Rebase

$ git range-diff --creation-factor=99 gh/isascii_c..gh/chkname isascii_c..chkname 
1:  e29f3481 ! 1:  a78a389c lib/string/ctype/isascii.h: ispfchar_c(): Add function
    @@ Metadata
     Author: Alejandro Colomar <alx@kernel.org>
     
      ## Commit message ##
    -    lib/string/ctype/isascii.h: ispfchar_c(): Add function
    +    lib/string/ctype/isascii.h: ispfchar_c(): Add macro
     
         This function returns true if the input character is a character from
         the POSIX portable filename character set.
    @@ Commit message
     
      ## lib/string/ctype/isascii.h ##
     @@
    - #define CTYPE_PRINT_C   CTYPE_GRAPH_C " "
    - #define CTYPE_XDIGIT_C  CTYPE_DIGIT_C "abcdefABCDEF"
    - #define CTYPE_ASCII_C   CTYPE_PRINT_C CTYPE_CNTRL_C /*NUL*/
    -+#define CTYPE_PFCHAR_C  CTYPE_ALNUM_C "._-"  // portable filename character set
    + #define CTYPE_PRINT_C     CTYPE_GRAPH_C " "
    + #define CTYPE_XDIGIT_C    CTYPE_DIGIT_C "abcdefABCDEF"
    + #define CTYPE_ASCII_C     CTYPE_PRINT_C CTYPE_CNTRL_C /*NUL*/
    ++#define CTYPE_PFCHAR_C    CTYPE_ALNUM_C "._-"  // portable filename character set
      
    - 
    - // isascii_c - is [:ascii:] C-locale
    + #define CTYPE_CNTRL_C0    CTYPE_CNTRL_C
    + #define CTYPE_CNTRL_C1                                                \
     @@
    - #define isgraph_c(c)   (!streq(strchrnul(CTYPE_GRAPH_C, c), ""))
    - #define isprint_c(c)   (!streq(strchrnul(CTYPE_PRINT_C, c), ""))
    - #define isxdigit_c(c)  (!streq(strchrnul(CTYPE_XDIGIT_C, c), ""))
    -+#define ispfchar_c(c)  (!streq(strchrnul(CTYPE_PFCHAR_C, c), ""))
    + #define isgraph_c(c)      (!streq(strchrnul(CTYPE_GRAPH_C, c), ""))
    + #define isprint_c(c)      (!streq(strchrnul(CTYPE_PRINT_C, c), ""))
    + #define isxdigit_c(c)     (!streq(strchrnul(CTYPE_XDIGIT_C, c), ""))
    ++#define ispfchar_c(c)     (!streq(strchrnul(CTYPE_PFCHAR_C, c), ""))
      
    - 
    - #endif  // include guard
    + // iscntrl_c0c1 - is control-character (C0 or C1)
    + #define iscntrl_c0c1(c)   (!!strchr(CTYPE_CNTRL_C0C1, c))
2:  4c8ed46a = 2:  08d72ce0 lib/chkname.c: is_valid_name(): Use isalnum(3) instead of its pattern
3:  831be018 = 3:  82202d26 lib/chkname.c: is_valid_name(): Split Samba check
4:  d3f1d69e ! 4:  4f120ee7 lib/chkname.c: is_valid_name(): Use ispfchar_c() to simplify
    @@ Commit message
         Signed-off-by: Alejandro Colomar <alx@kernel.org>
     
      ## lib/chkname.c ##
    -@@
    - 
    - #include "defines.h"
    - #include "chkname.h"
    -+#include "string/ctype/isascii.h"
    - #include "string/ctype/strchrisascii.h"
    - #include "string/ctype/strisascii.h"
    - #include "string/strcmp/streq.h"
     @@ lib/chkname.c: is_valid_name(const char *name)
         * sake of Samba 3.x "add machine script"
         */

v5

Rebase

$ git range-diff gh/isascii_c..gh/chkname isascii_c..chkname 
1:  a78a389c ! 1:  ff1fd936 lib/string/ctype/isascii.h: ispfchar_c(): Add macro
    @@ lib/string/ctype/isascii.h
      #define CTYPE_ASCII_C     CTYPE_PRINT_C CTYPE_CNTRL_C /*NUL*/
     +#define CTYPE_PFCHAR_C    CTYPE_ALNUM_C "._-"  // portable filename character set
      
    - #define CTYPE_CNTRL_C0    CTYPE_CNTRL_C
    - #define CTYPE_CNTRL_C1                                                \
    + 
    + // isascii_c - is [:ascii:] C-locale
     @@
      #define isgraph_c(c)      (!streq(strchrnul(CTYPE_GRAPH_C, c), ""))
      #define isprint_c(c)      (!streq(strchrnul(CTYPE_PRINT_C, c), ""))
      #define isxdigit_c(c)     (!streq(strchrnul(CTYPE_XDIGIT_C, c), ""))
     +#define ispfchar_c(c)     (!streq(strchrnul(CTYPE_PFCHAR_C, c), ""))
      
    - // iscntrl_c0c1 - is control-character (C0 or C1)
    - #define iscntrl_c0c1(c)   (!!strchr(CTYPE_CNTRL_C0C1, c))
    + 
    + // strisascii_c - string is [:ascii:] C-locale
2:  08d72ce0 = 2:  658309d8 lib/chkname.c: is_valid_name(): Use isalnum(3) instead of its pattern
3:  82202d26 = 3:  cc2eaf17 lib/chkname.c: is_valid_name(): Split Samba check
4:  4f120ee7 = 4:  15452a8f lib/chkname.c: is_valid_name(): Use ispfchar_c() to simplify

v5b

Rebase

$ git range-diff gh/isascii_c..gh/chkname isascii_c..chkname 
1:  ff1fd936 = 1:  42e056d4 lib/string/ctype/isascii.h: ispfchar_c(): Add macro
2:  658309d8 = 2:  277c74a4 lib/chkname.c: is_valid_name(): Use isalnum(3) instead of its pattern
3:  cc2eaf17 = 3:  ada55b69 lib/chkname.c: is_valid_name(): Split Samba check
4:  15452a8f = 4:  0d554596 lib/chkname.c: is_valid_name(): Use ispfchar_c() to simplify

v5c

Rebase

$ git range-diff gh/isascii_c..gh/chkname isascii_c..chkname 
1:  42e056d4 = 1:  9e750a07 lib/string/ctype/isascii.h: ispfchar_c(): Add macro
2:  277c74a4 = 2:  81c2ba62 lib/chkname.c: is_valid_name(): Use isalnum(3) instead of its pattern
3:  ada55b69 = 3:  87aa2cf5 lib/chkname.c: is_valid_name(): Split Samba check
4:  0d554596 = 4:  4d0acb92 lib/chkname.c: is_valid_name(): Use ispfchar_c() to simplify

v5d

Rebase

$ git range-diff 9e750a07c325^..gh/chkname isascii_c..chkname 
1:  9e750a07c325 = 1:  cd57500e79d8 lib/string/ctype/isascii.h: ispfchar_c(): Add macro
2:  81c2ba628fdc = 2:  6100dd972f4b lib/chkname.c: is_valid_name(): Use isalnum(3) instead of its pattern
3:  87aa2cf5cf8e = 3:  4dce9410ad58 lib/chkname.c: is_valid_name(): Split Samba check
4:  4d0acb92c588 = 4:  604fb99f8a2f lib/chkname.c: is_valid_name(): Use ispfchar_c() to simplify

v6

Rebase

$ git rd 
 1:  e28a0f4456c3 <  -:  ------------ lib/string/ctype/isascii.[ch]: is*_c(): Add APIs
 2:  b9c6a8e5c2a6 <  -:  ------------ lib/, src/: Use isascii_c() functions instead of isascii(3)
 3:  4d1f1e04feea <  -:  ------------ lib/: Merge directories "lib/string/ctype/*" into unified files
 4:  fcbf29261d17 <  -:  ------------ lib/string/ctype/strisascii.h: strisprint(): Simplify implementation
 5:  07546a3c18f7 <  -:  ------------ lib/string/ctype/strisascii.h: Compact definitions
 6:  891d6e726735 <  -:  ------------ lib/: stris*(): Rename C-locale APIs with a _c suffix
 7:  d01f482b737b <  -:  ------------ lib/string/ctype/strchrisascii.h: Use strpbrk(3) to simplify
 8:  822dbad4b220 <  -:  ------------ lib/fields.c: valid_field(): Check empty string before strisprint_c()
 9:  a5c2dd159645 <  -:  ------------ lib/string/ctype/strisascii.*: Don't special-case ""
10:  a39d16aaaa17 <  -:  ------------ lib/: Merge "lib/string/ctype/*" files even further
11:  cd57500e79d8 =  1:  470864e06510 lib/string/ctype/isascii.h: ispfchar_c(): Add macro
12:  6100dd972f4b =  2:  edb94eaff5be lib/chkname.c: is_valid_name(): Use isalnum(3) instead of its pattern
13:  4dce9410ad58 =  3:  029a114070bd lib/chkname.c: is_valid_name(): Split Samba check
14:  604fb99f8a2f =  4:  787abbfed42b lib/chkname.c: is_valid_name(): Use ispfchar_c() to simplify

v6b

Change intermediate commit to use isalnum_c() instead of isalnum(3).

range-diff

$ git rd 
1:  470864e06510 = 1:  470864e06510 lib/string/ctype/isascii.h: ispfchar_c(): Add macro
2:  edb94eaff5be ! 2:  cd6ff74b1163 lib/chkname.c: is_valid_name(): Use isalnum(3) instead of its pattern
    @@ Metadata
     Author: Alejandro Colomar <alx@kernel.org>
     
      ## Commit message ##
    -    lib/chkname.c: is_valid_name(): Use isalnum(3) instead of its pattern
    +    lib/chkname.c: is_valid_name(): Use isalnum_c() instead of its pattern
     
         Signed-off-by: Alejandro Colomar <alx@kernel.org>
     
    @@ lib/chkname.c: is_valid_name(const char *name)
     -  if (!((*name >= 'a' && *name <= 'z') ||
     -        (*name >= 'A' && *name <= 'Z') ||
     -        (*name >= '0' && *name <= '9') ||
    -+  if (!(isalnum(*name) ||
    ++  if (!(isalnum_c(*name) ||
              *name == '_' ||
              *name == '.'))
        {
    @@ lib/chkname.c: is_valid_name(const char *name)
     -          if (!((*name >= 'a' && *name <= 'z') ||
     -                (*name >= 'A' && *name <= 'Z') ||
     -                (*name >= '0' && *name <= '9') ||
    -+          if (!(isalnum(*name) ||
    ++          if (!(isalnum_c(*name) ||
                      *name == '_' ||
                      *name == '.' ||
                      *name == '-' ||
3:  029a114070bd ! 3:  e81736c0a8cc lib/chkname.c: is_valid_name(): Split Samba check
    @@ lib/chkname.c: is_valid_name(const char *name)
     +          if (streq(name, "$"))  // Samba
     +                  return true;
     +
    -           if (!(isalnum(*name) ||
    +           if (!(isalnum_c(*name) ||
                      *name == '_' ||
                      *name == '.' ||
     -                *name == '-' ||
4:  787abbfed42b ! 4:  721567e137de lib/chkname.c: is_valid_name(): Use ispfchar_c() to simplify
    @@ lib/chkname.c: is_valid_name(const char *name)
         * sake of Samba 3.x "add machine script"
         */
      
    --  if (!(isalnum(*name) ||
    +-  if (!(isalnum_c(*name) ||
     -        *name == '_' ||
     -        *name == '.'))
     -  {
    @@ lib/chkname.c: is_valid_name(const char *name)
                if (streq(name, "$"))  // Samba
                        return true;
      
    --          if (!(isalnum(*name) ||
    +-          if (!(isalnum_c(*name) ||
     -                *name == '_' ||
     -                *name == '.' ||
     -                *name == '-'

interdiff

$ git diff gh/chkname..chkname 
$

v7

Add APIs for handling LDH from RFC1035.

$ git rd 
1:  470864e06510 = 1:  470864e06510 lib/string/ctype/isascii.h: ispfchar_c(): Add macro
2:  cd6ff74b1163 = 2:  cd6ff74b1163 lib/chkname.c: is_valid_name(): Use isalnum_c() instead of its pattern
3:  e81736c0a8cc = 3:  e81736c0a8cc lib/chkname.c: is_valid_name(): Split Samba check
4:  721567e137de = 4:  721567e137de lib/chkname.c: is_valid_name(): Use ispfchar_c() to simplify
-:  ------------ > 5:  97fd538ffe77 lib/string/ctype/isascii.h: Increase white-space alignment
-:  ------------ > 6:  a06e755548de lib/string/ctype/isascii.h: Add variants for handling LDH from RFC1035
-:  ------------ > 7:  188d2acc0830 lib/chkname.c: Use strisldh_rfc1035_c() instead of its pattern

Resolved.

This function returns true if the input character is a character from the POSIX portable filename character set. Link: <https://pubs.opengroup.org/onlinepubs/9799919799/basedefs/V1_chap03.html#tag_03_265> Signed-off-by: Alejandro Colomar <alx@kernel.org>

Signed-off-by: Alejandro Colomar <alx@kernel.org>

In the first case, we can do the transformation because a few lines above, we explicitly reject a name starting with a '-'. In the second case, we're obviously using ispfchar_c() instead of its pattern. Signed-off-by: Alejandro Colomar <alx@kernel.org>

This is in preparation for the next commit. Signed-off-by: Alejandro Colomar <alx@kernel.org>

Link: <https://datatracker.ietf.org/doc/html/rfc1035#section-2.3.1> Signed-off-by: Alejandro Colomar <alx@kernel.org>

Signed-off-by: Alejandro Colomar <alx@kernel.org>

alejandro-colomar requested review from hallyn and ikerexxe January 1, 2026 00:40

alejandro-colomar self-assigned this Jan 1, 2026

alejandro-colomar force-pushed the chkname branch from f97b10f to 1ead5c6 Compare January 1, 2026 00:42

alejandro-colomar added the New API label Jan 1, 2026

alejandro-colomar force-pushed the chkname branch 2 times, most recently from 8fd9e48 to d39008c Compare January 2, 2026 00:59

stoeckmann suggested changes Jan 2, 2026

View reviewed changes

Comment thread lib/string/ctype/isascii/ispfchar.h Outdated

alejandro-colomar marked this pull request as draft January 2, 2026 19:35

alejandro-colomar force-pushed the chkname branch 3 times, most recently from e371b46 to 000c8c1 Compare January 3, 2026 16:56

alejandro-colomar requested a review from stoeckmann January 3, 2026 16:58

stoeckmann previously requested changes Jan 3, 2026

View reviewed changes

Comment thread lib/chkname.c

alejandro-colomar force-pushed the chkname branch from 000c8c1 to ed15a3c Compare February 23, 2026 14:39

alejandro-colomar force-pushed the chkname branch from ed15a3c to 42b2e85 Compare March 4, 2026 16:48

alejandro-colomar force-pushed the chkname branch 2 times, most recently from d3f1d69 to 4f120ee Compare March 13, 2026 00:29

alejandro-colomar force-pushed the chkname branch 2 times, most recently from 15452a8 to 0d55459 Compare April 7, 2026 13:42

alejandro-colomar force-pushed the chkname branch from 0d55459 to 4d0acb9 Compare May 15, 2026 14:36

alejandro-colomar force-pushed the chkname branch from 4d0acb9 to 604fb99 Compare June 10, 2026 10:33

alejandro-colomar force-pushed the chkname branch from 604fb99 to 787abbf Compare June 20, 2026 16:22

alejandro-colomar marked this pull request as ready for review June 20, 2026 16:22

alejandro-colomar added 3 commits June 20, 2026 21:54

lib/chkname.c: is_valid_name(): Use isalnum_c() instead of its pattern

cd6ff74

Signed-off-by: Alejandro Colomar <alx@kernel.org>

lib/chkname.c: is_valid_name(): Split Samba check

e81736c

Signed-off-by: Alejandro Colomar <alx@kernel.org>

alejandro-colomar force-pushed the chkname branch from 787abbf to 721567e Compare June 20, 2026 19:58

alejandro-colomar added 3 commits June 20, 2026 22:20

lib/string/ctype/isascii.h: Increase white-space alignment

97fd538

This is in preparation for the next commit. Signed-off-by: Alejandro Colomar <alx@kernel.org>

lib/string/ctype/isascii.h: Add variants for handling LDH from RFC1035

a06e755

Link: <https://datatracker.ietf.org/doc/html/rfc1035#section-2.3.1> Signed-off-by: Alejandro Colomar <alx@kernel.org>

lib/chkname.c: Use strisldh_rfc1035_c() instead of its pattern

188d2ac

Signed-off-by: Alejandro Colomar <alx@kernel.org>

alejandro-colomar changed the title ~~lib/: Add ispfchar(), and use it instead of its pattern~~ lib/string/ctype: Add ispfchar_c() and strisldh_rfc1035_c(), and use them instead of their pattern Jun 20, 2026

alejandro-colomar changed the title ~~lib/string/ctype: Add ispfchar_c() and strisldh_rfc1035_c(), and use them instead of their pattern~~ lib/: Add ispfchar_c() and strisldh_rfc1035_c(), and use them instead of their pattern Jun 20, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

lib/: Add ispfchar_c() and strisldh_rfc1035_c(), and use them instead of their pattern#1469

lib/: Add ispfchar_c() and strisldh_rfc1035_c(), and use them instead of their pattern#1469
alejandro-colomar wants to merge 7 commits into
shadow-maint:masterfrom
alejandro-colomar:chkname

alejandro-colomar commented Jan 1, 2026 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

alejandro-colomar commented Jan 1, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

alejandro-colomar commented Jan 1, 2026 •

edited

Loading