ci: add markdownlint job to CI - #696
Conversation
Add a markdownlint job that runs on all .md files using the igorshubovych/markdownlint-cli Docker image. Includes a config file to disable MD013 (line length) and MD003 (heading style) rules to avoid false positives on existing documentation. Fixes servo#692
39fde95 to
0988126
Compare
| "MD013": false, | ||
| "MD003": false, | ||
| "MD009": false, | ||
| "MD032": false, | ||
| "MD047": false |
There was a problem hiding this comment.
why disable these??
shouldn't we just have it default??
maybe even remove the file
if changes are needed, we can tweak the documentation
There was a problem hiding this comment.
Fixed some files and I think we should disable line length or bump it to 100 accordingly. The decision remains upto you
Signed-off-by: Gauravpawar101 <Gauravpawar2522@gmail.com>
|
@alejandro-vaz that'swhat I am asking let's bump line len to 100 and then do those line changes as some are 150~ |
|
nah I'd say normally split it doesn't really matter whether it's 80 or 100 but setting it to a 100 is more cumbersome (wouldn't we have to add a markdownlint file??) and the resulting readme it's the same so why complicate it |
|
@alejandro-vaz please take this into consideraton we would not be able to write appropriately with 80, too little headspace I recommend atleast a 100 Feature List
Note
|
|
if as of now no separate config, we can do it in CI but that would not be appealing tho |
|
honestly I got lost why can't we simply split?? I lost the thread of the argument |
Signed-off-by: Gauravpawar101 <Gauravpawar2522@gmail.com>
|
Wait a minute fixing |
|
hhahhah still didn't go green, markdownlint is hell no worries, have time |
alejandro-vaz
left a comment
There was a problem hiding this comment.
.github/CODE_OF_CONDUCT.md:3:88 MD047/single-trailing-newline Files should end with a single newline character
.github/CONTRIBUTING.md:1 MD041/first-line-heading/first-line-h1 First line in a file should be a top-level heading [Context: "## Contributing Guidelines"]
.github/README.md:4:81 MD013/line-length Line length [Expected: 80; Actual: 92]
.github/README.md:5:81 MD013/line-length Line length [Expected: 80; Actual: 139]
.github/README.md:6:2 MD009/no-trailing-spaces Trailing spaces [Expected: 0 or 2; Actual: 1]
.github/README.md:11:81 MD013/line-length Line length [Expected: 80; Actual: 162]
.github/README.md:26:1 MD033/no-inline-html Inline HTML [Element: a]
.github/README.md:27:3 MD033/no-inline-html Inline HTML [Element: img]
.github/README.md:27:3 MD045/no-alt-text Images should have alternate text (alt text)
.github/README.md:28:4 MD047/single-trailing-newline Files should end with a single newline character
Signed-off-by: Gauravpawar101 <Gauravpawar2522@gmail.com>
Sgned-off-by: Gauravpawar101 <Gauravpawar2522@gmail.com>
alejandro-vaz
left a comment
There was a problem hiding this comment.
thanks @GauravPawar101, sorry for the long back-and-forth
Add a markdownlint job that runs on all .md files using the igorshubovych/markdownlint-cli Docker image. Includes a config file to disable MD013 (line length) and MD003 (heading style) rules to avoid false positives on existing documentation.
Fixes #692