chore: drop needless borrows flagged by clippy 1.97 - #457
Merged
andrius-puksta-sensmetry merged 2 commits intoJul 20, 2026
Merged
Conversation
consideRatio
changed the title
andrius-puksta-sensmetry
approved these changes
Jul 20, 2026
andrius-puksta-sensmetry
enabled auto-merge (squash)
July 20, 2026 05:21
andrius-puksta-sensmetry
disabled auto-merge
July 20, 2026 05:22
andrius-puksta-sensmetry
enabled auto-merge (squash)
July 20, 2026 05:24
1 task
The prek CI job runs a newer clippy than the 1.96 pinned by rust-toolchain.toml and its --fix pass rewrote three pre-existing needless borrows (in format!/log macro arguments), failing the hook with 'files were modified'. Apply those three one-line fixes so the hook is a no-op on both clippy versions. Pre-existing code, not part of the credential work; upstream may want to align the prek job's toolchain with rust-toolchain.toml separately. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01EfyrkJkeo3mRngVoppJjUN Signed-off-by: Erik Sundell <erik.sundell+2025@sensmetry.com>
Completes the previous drift commit: running the prek hook's exact clippy command under the CI runner's actual toolchain (1.97, released 2026-07-14) locally flushes the full fix set at once instead of discovering one file per CI round. A second 1.97 pass is now a no-op. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01EfyrkJkeo3mRngVoppJjUN Signed-off-by: Erik Sundell <erik.sundell+2025@sensmetry.com>
consideRatio
force-pushed
the
style/clippy-197-needless-borrows
branch
from
July 20, 2026 06:56
44e69cc to
e7f58cb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Clippy with Rust 1.97 makes a few fixes, and currenty prek in our CI system makes use of Rust 1.97 even though we mean to have us pinned to 1.96. This is fixed by #454. However, this PR applies the things clippy 1.97 did.