Repository navigation
Cover the orphan index entry under ABCI queries too - #4695
Conversation
|
I'll fix CI failures and address comments from users with write access that start with 'Devin'.
|
|
The latest Buf updates on your PR. Results from workflow Buf / buf (pull_request).
|
PR SummaryLow Risk Overview Each subtest calls Reviewed by Cursor Bugbot for commit 3b6469d. Bugbot is set up for automated code reviews on this repo. Configure here. |
There was a problem hiding this comment.
The change is test-only. It runs TestGRPCQueryValidatorDelegationsOrphanIndexEntry under both abciQuery values, so an index entry with no delegation is now checked on the FilteredPaginate (ABCI) path as well as FilteredPaginateV66. FilteredPaginateForContext routes on ctx.IsABCIQuery(), so both subtests reach the nil guard in validatorDelegationsFromIndex, and the per-subtest SetupTest() copies the sibling test; I found nothing blocking. Codex reported no findings, and I agree, so it added nothing to keep or drop. The test was not run because there is no Go toolchain in the sandbox.
seidroid review · decision approve · session 7c65cae568524ed49e3af773fb2f0df2 · turn resp_claude_720e510378a6586b7995d04432d043d4 · item 130b7db25d445e7a94d1e0b0b26ea53e
Findings: 0 blocking | 0 non-blocking | 0 posted inline
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4695 +/- ##
==========================================
- Coverage 60.26% 60.26% -0.01%
==========================================
Files 2027 2027
Lines 158078 158078
==========================================
- Hits 95270 95265 -5
- Misses 62803 62808 +5
Partials 5 5
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
TestGRPCQueryValidatorDelegationsOrphanIndexEntry, added in #4688, only ran in the consensus context, which pages the delegation-by-validator index throughFilteredPaginateV66. ABCI queries page it throughFilteredPaginateinstead, so the check that an index entry without its delegation returnsInternalhad no coverage on that path.The test now runs under both
abciQueryvalues, likeTestGRPCQueryValidatorDelegationsScanCursorAfterIndexReadybeside it. Test-only, with no consensus or state impact. Both subtests fail with the nil guard invalidatorDelegationsFromIndexremoved.