fix: sort integration types & contexts before comparing - #871
Merged
favna merged 2 commits intoAug 22, 2026
Merged
Conversation
vladfrangu
requested changes
Aug 15, 2026
vladfrangu
left a comment
vladfrangu
left a comment
Member
There was a problem hiding this comment.
Please use a sorting function instead of default sorting behavior
Contributor
Author
Oops, yeah. Forgot the default sorting converts the values to strings before comparing, considering these are numbers that could have caused issues. |
vladfrangu
approved these changes
Aug 15, 2026
favna
approved these changes
Aug 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is basically a slightly simplified version of #866.
As the issue explains this currently causes any chat input command with
contextsand/orintegration_typesto be diffed incorrectly triggering unnecessary command updates.Fixes #865