Cancel pending review when deleting a record - #50
Merged
Merged
Conversation
Close the moderation lane when a pending record is deleted: cancel open reviews through the append-only review transition table, reject the pending revision, clear pending_revision_id, and backfill already-deleted records with the same zombie-review state. Add regression coverage that mirrors the live v0.5.1 acceptance failure.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
pending_revision_idselene-labacceptanceValidation
ECONNRESETflakes remain in Slice 1npm run check: 0 errors / 0 warnings / 2 pre-existing hints