build: Bump rust-vmm-ci to c41370c#354
Conversation
RuoqingHe
requested review from
ShadowCurse,
acatangiu,
andreeaflorescu,
lauralt,
roypat and
sameo
as code owners
|
seems like no_run tests are still compiled. I guess this one needs some imports behind |
I'm in the middle of addressing this, it looks like this snippet is outdated, it looks like |
admittedly, this snippet was never meant to actually compile or anything, it was just some pseudo code to illuminate the calculation |
RuoqingHe
force-pushed
the
bump-rust-vmm-ci-to-c41370c
branch
from
80fb106 to
aaa4072
Compare
| /// ```no_run | ||
| /// # use kvm_bindings::{__u32, kvm_xsave, KVM_CAP_XSAVE2}; | ||
| /// # use libc::{c_char, open, O_RDWR}; | ||
| /// # use std::fs::File; | ||
| /// # use std::os::unix::io::FromRawFd; | ||
| /// # use vmm_sys_util::{ioctl::ioctl_with_val, ioctl_io_nr}; | ||
| /// # const KVM_PATH: &str = "/dev/kvm\0"; | ||
| /// # const KVMIO: u32 = 0x03; | ||
| /// # let kvm_fd = unsafe { open(KVM_PATH.as_ptr() as *const c_char, O_RDWR) }; | ||
| /// # assert!(kvm_fd >= 0); | ||
| /// # ioctl_io_nr!(KVM_CHECK_EXTENSION, KVMIO, 0x03); | ||
| /// | ||
| /// ((unsafe { | ||
| /// ioctl_with_val( | ||
| /// &File::from_raw_fd(kvm_fd), | ||
| /// KVM_CHECK_EXTENSION(), | ||
| /// KVM_CAP_XSAVE2.into(), | ||
| /// ) | ||
| /// }) as usize | ||
| /// - size_of::<kvm_xsave>()) | ||
| /// .div_ceil(size_of::<__u32>()); |
There was a problem hiding this comment.
I really do think this is clearer as just the pseudo code it was before :/
There was a problem hiding this comment.
Should I just remove this code snippet (the surrounding ```), and perhaps use (KVM_CHECK_EXTENSION(KVM_CAP_XSAVE2) - sizeof::<kvm_xsave>()).div_ceil(sizeof::<__u32>()) instead
Test cases introduced by SBI related changes require SBI_V01 to be enabled during kernel compilation. At the point of `042b206` already incorporates `c41370c`, which is capable of covering this case. Signed-off-by: Ruoqing He <heruoqing@iscas.ac.cn>
RuoqingHe
force-pushed
the
bump-rust-vmm-ci-to-c41370c
branch
from
aaa4072 to
7c8cc06
Compare
4 participants
Summary of the PR
Test cases introduced by SBI related changes require SBI_V01 to be enabled during kernel compilation.
c41370cis capable of covering this case.Unblocks #352.
Requirements
Before submitting your PR, please make sure you addressed the following
requirements:
git commit -s), and the commit message has max 60 characters for thesummary and max 75 characters for each description line.
test.
Release" section of CHANGELOG.md (if no such section exists, please create one).
unsafecode is properly documented.