Conversation
9fbf466 to
8063d99
Compare
|
The bench suite now passes but the upload failed. I'll have to reorganize the history and contact admins tomorrow so that we can have codspeed authenticated here. |
abce910 to
53735cc
Compare
53735cc to
22bb15a
Compare
|
The history is reorganized and the bench suite is parsing (the upload step still fails because I still have to contact admins). The Linux CI fails due to other build/cache errors I believe, which doesn't seem related to this patch. |
| /// Returns the name of the enclosing function. | ||
| /// | ||
| /// Borrowed from <https://docs.rs/stdext/0.3.3/src/stdext/macros.rs.html#63-74>, | ||
| /// original code licensed under MIT. | ||
| macro_rules! fn_name { | ||
| () => {{ | ||
| // Okay, this is ugly, I get it. However, this is the best we can get on a stable rust. | ||
| fn f() {} | ||
| fn type_name_of<T>(_: T) -> &'static str { | ||
| std::any::type_name::<T>() | ||
| } | ||
| let name = type_name_of(f); | ||
| // `3` is the length of the `::f`. | ||
| &name[..name.len() - 3] | ||
| }}; | ||
| } |
There was a problem hiding this comment.
I don't think this is worth it. Just repeat the names as a string constant?
|
@djc Thanks for the quick review! I'd love to address the remaining concerns, but it looks like this PR will have to pass the admins' discussions first to move on, so I'm moving this back to draft state :) |
What discussion? Should have a link in the PR description. |
Here's the thread FWIW: https://rust-lang.zulipchat.com/#narrow/channel/242791-t-infra/topic/Giving.20codspeed.20permissions.20to.20rust-lang.2Frustup/with/626822759 |
This branch has not been deployed
2 participants
Note
GPT 5.6 Luna is used to analyze https://github.com/rustls/upki 's bench suite and to generate a part of the GitHub CI file.
Closes #5103.