Add BTF relocation builtins by vadorovsky · Pull Request #161107 · rust-lang/rust

vadorovsky · 2026-08-14T16:57:35Z

Add experimental Rust support for Compile Once, Run Everywhere (CO-RE) relocations based on the BPF Type Format (BTF). The entire feature is specific to the BPF architecture and cannot be used elsewhere. The feature introduces a #[btf_relocatable] attribute for structs and unions whose field layout must be queried through BTF-aware operations, and adds BTF-aware bultins:

btf_field_exists
btf_field_byte_offset
btf_field_byte_size

This PR does not yet expose these builtins to the users, the core_arch API will be added as a follow-up change.

The user-facing feature is gated by #![feature(btf_relocations)].

See individual commits for details.

Created with the help of an LLM, initially used to analyze the existing MIR, codegen SSA and LLVM backend code, to help identifying which parts of code need modification. Afterwards, the code and commit messages were written by hand, then reviewed by an LLM.

Tracking issue: #160616
RFC: rust-lang/rfcs#3966

r? @traviscross @nagisa

rustbot · 2026-08-14T16:57:38Z

Some changes occurred to MIR optimizations

cc @rust-lang/wg-mir-opt

This PR changes MIR

cc @oli-obk, @RalfJung, @JakobDegen, @vakaras

Some changes occurred to constck

cc @fee1-dead

stdarch is developed in its own repository. If possible, consider making this change to rust-lang/stdarch instead.

cc @Amanieu, @folkertdev, @sayantn

This PR changes rustc_public

cc @oli-obk, @celinval, @ouz-a, @makai410

Some changes occurred to the CTFE machinery

cc @RalfJung, @oli-obk, @lcnr

Some changes occurred in compiler/rustc_passes/src/check_attr.rs

cc @jdonszelmann, @JonathanBrouwer

rustc_codegen_cranelift is developed in its own repository. If possible, consider making this change to rust-lang/rustc_codegen_cranelift instead.

cc @bjorn3

Some changes occurred in match checking

cc @Nadrieril

Some changes occurred in compiler/rustc_attr_parsing

cc @jdonszelmann, @JonathanBrouwer

Some changes occurred in compiler/rustc_attr_ir

cc @jdonszelmann, @JonathanBrouwer

Some changes occurred in rustc_ty_utils::consts.rs

cc @BoxyUwU

The parser was modified, potentially altering the grammar of (stable) Rust
which would be a breaking change.

cc @fmease

Some changes occurred to the CTFE / Miri interpreter

cc @rust-lang/miri

vadorovsky · 2026-08-14T20:01:12Z

stdarch is developed in its own repository. If possible, consider making this change to rust-lang/stdarch instead.

cc @Amanieu, @folkertdev, @sayantn

[...]

rustc_codegen_cranelift is developed in its own repository. If possible, consider making this change to rust-lang/rustc_codegen_cranelift instead.

cc @bjorn3

Sorry, I will trim this PR only to the builtins. They can be still tested with minicore and a macro embedded in test. And I'm going to leave the core_arch change for later.

vadorovsky · 2026-08-15T07:11:20Z

Now CI fails on rustc_codegen_cranelift. https://github.com/rust-lang/rust/actions/runs/31870909600/job/94979319914 How do we usually fix such chicken-and-egg problems?

Register the unstable `btf_relocations` feature and add the `#[btf_relocatable]` built-in attribute for structs and unions, that can be used only on BPF architecture. Preserve the attribute in crate metadata, add UI coverage for feature gating and attribute target validation.

Reject field projection and `offset_off!` usage on `#[btf_relocatable]` types.

Add builtin macros for requesting BTF field information from the Rust compiler's frontend perspective: * `btf_field_byte_offset` * `btf_field_byte_size` * `btf_field_exists` Parse them as `BtfFieldInfo` expressions, that carry the kind of requested information (offset, size, exists), base type and the field path. This mechanism supports nested field accesses in one query. Compile these expressions to `BtfFieldInfo` RValue. Add `btf_field_info` method to the `BuilderMethods` trait in codegen SSA, and use it for lowering the `BtfFieldInfo` RValue. Backends without BTF relocation support report an error. Support in backends will be added in follow-up changes. This change does not expose the functionality to the users. A user-facing API will also be added in a follow-up change.

Expose wrappers for the `llvm.preserve.struct.access.index` and `llvm.preserve.union.access.index` intrinsics. Lower backend-neutral BTF field paths by mapping Rust field indices to LLVM aggregate indices and emitting the corresponding intrinsic calls (`llvm.preserve.{struct,union}.access.index`). Pass the resulting field pointer to `llvm.bpf.preserve.field.info`.

Test the `btf_field_exists`, `btf_field_byte_offset` and `btf_field_byte_size` builtins and make sure they emit correct LLVM intrinsic calls.

rust-log-analyzer · 2026-08-15T07:30:45Z

The job pr-check-2 failed! Check out the build log: (web) (plain enhanced) (plain)

Click to see the possible cause of the failure (guessed by this bot)

    Checking cranelift-object v0.134.0
[RUSTC-TIMING] cranelift_frontend test:false 0.209
[RUSTC-TIMING] cranelift_object test:false 0.097
    Checking rustc_codegen_cranelift v0.1.0 (/checkout/compiler/rustc_codegen_cranelift)
error[E0004]: non-exhaustive patterns: `rustc_middle::mir::Rvalue::BtfFieldInfo { .. }` not covered
    --> compiler/rustc_codegen_cranelift/src/base.rs:632:19
     |
 632 |             match to_place_and_rval.1 {
     |                   ^^^^^^^^^^^^^^^^^^^ pattern `rustc_middle::mir::Rvalue::BtfFieldInfo { .. }` not covered
     |
note: `rustc_middle::mir::Rvalue<'_>` defined here
    --> compiler/rustc_middle/src/mir/syntax.rs:1342:1
     |
1342 | pub enum Rvalue<'tcx> {
     | ^^^^^^^^^^^^^^^^^^^^^
...
1469 |     BtfFieldInfo { base_ty: Ty<'tcx>, path: Box<[BtfFieldStep<'tcx>]>, kind: BtfFieldInfoKind },
     |     ------------ not covered
     = note: the matched value is of type `rustc_middle::mir::Rvalue<'_>`
help: ensure that all possible cases are being handled by adding a match arm with a wildcard pattern or an explicit pattern as shown
     |
 924 ~                 Rvalue::CopyForDeref(_) => bug!("`CopyForDeref` in codegen"),
 925 ~                 rustc_middle::mir::Rvalue::BtfFieldInfo { .. } => todo!(),
     |

For more information about this error, try `rustc --explain E0004`.
[RUSTC-TIMING] rustc_codegen_cranelift test:false 0.944
error: could not compile `rustc_codegen_cranelift` (lib) due to 1 previous error

rust-bors · 2026-08-16T13:48:00Z

☔ The latest upstream changes (presumably #160889) made this pull request unmergeable. Please resolve the merge conflicts by rebasing.

RalfJung · 2026-08-16T16:07:49Z

    Reborrow(Ty<'tcx>, Mutability, Place<'tcx>),
+
+    /// Queries BTF metadata for a statically resolved field path.
+    BtfFieldInfo { base_ty: Ty<'tcx>, path: Box<[BtfFieldStep<'tcx>]>, kind: BtfFieldInfoKind },


This is a very unusual MIR construct, to put it quite mildly. Please add a bit more detail. What is this "metadata" that is being queried and how is it returned? What are the validity conditions? When is this operation UB (if ever)?

We usually work very hard to keep target-specific things away from this core part of the compiler, so seeing BTF-specific things here is somewhat alarming.

View changes since the review

Also, please write comments in this part in the compiler assuming that the reader never heard of BTF or BPF before. So, always include a link for such acronyms.

RalfJung · 2026-08-16T16:09:56Z

+            Self::ByteOffset => 0,
+            Self::ByteSize => 1,
+            Self::Exists => 2,


Where do these constants come from? Can rustc just do whatever it wants here or are these magic constants defined by some outside protocol?

View changes since the review

RalfJung · 2026-08-16T16:11:24Z

            }
+
+            BtfFieldInfo { .. } => {
+                throw_unsup_format!("BTF field relocation queries cannot be interpreted");


FWIW Miri will probably eventually want to support these, so for stabilization we need to consider what to do. But for now this is fine.

View changes since the review

RalfJung · 2026-08-16T16:11:47Z

    (unstable, bpf_target_feature, "1.54.0", Some(150247)),
+    // no-tracking-issue-start
+    /// Allows BTF CO-RE field relocation queries.
+    (unstable, btf_relocations, "CURRENT_RUSTC_VERSION", None),


You do have a tracking issue though...?

View changes since the review

rustbot added the A-attributes Area: Attributes (`#[…]`, `#![…]`) label Aug 14, 2026

rustbot assigned traviscross Aug 14, 2026

This comment has been minimized.

Sign in to view

vadorovsky force-pushed the vad/btf-relocations branch from 7de4ec2 to 869a54b Compare August 15, 2026 07:01

This comment has been minimized.

Sign in to view

vadorovsky added 5 commits August 15, 2026 09:20

Reject direct field access on BTF-relocatable types

f787ca4

Reject field projection and `offset_off!` usage on `#[btf_relocatable]` types.

Add codegen test for BTF relocations

b42b869

Test the `btf_field_exists`, `btf_field_byte_offset` and `btf_field_byte_size` builtins and make sure they emit correct LLVM intrinsic calls.

vadorovsky force-pushed the vad/btf-relocations branch from 869a54b to b42b869 Compare August 15, 2026 07:23

vadorovsky changed the title ~~BTF relocations~~ Add BTF relocation builtins Aug 15, 2026

RalfJung reviewed Aug 16, 2026

View reviewed changes

Navigation Menu

Uh oh!

Uh oh!

Add BTF relocation builtins - #161107

Add BTF relocation builtins#161107
vadorovsky wants to merge 5 commits into
rust-lang:mainfrom
vadorovsky:vad/btf-relocations

vadorovsky commented Aug 14, 2026 •

edited

Loading

Uh oh!

rustbot commented Aug 14, 2026

Uh oh!

This comment has been minimized.

vadorovsky commented Aug 14, 2026

Uh oh!

This comment has been minimized.

vadorovsky commented Aug 15, 2026

Uh oh!

rust-log-analyzer commented Aug 15, 2026

Uh oh!

rust-bors Bot commented Aug 16, 2026

Uh oh!

RalfJung Aug 16, 2026 •

edited by rustbot

Loading

Uh oh!

RalfJung Aug 16, 2026

Uh oh!

RalfJung Aug 16, 2026 •

edited by rustbot

Loading

Uh oh!

RalfJung Aug 16, 2026 •

edited by rustbot

Loading

Uh oh!

RalfJung Aug 16, 2026 •

edited by rustbot

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Uh oh!

Uh oh!

Conversation

vadorovsky commented Aug 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rustbot commented Aug 14, 2026

Uh oh!

This comment has been minimized.

vadorovsky commented Aug 14, 2026

Uh oh!

This comment has been minimized.

vadorovsky commented Aug 15, 2026

Uh oh!

rust-log-analyzer commented Aug 15, 2026

Uh oh!

rust-bors Bot commented Aug 16, 2026

Uh oh!

RalfJung Aug 16, 2026 • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

RalfJung Aug 16, 2026

Choose a reason for hiding this comment

Uh oh!

RalfJung Aug 16, 2026 • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

RalfJung Aug 16, 2026 • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

RalfJung Aug 16, 2026 • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

vadorovsky commented Aug 14, 2026 •

edited

Loading

RalfJung Aug 16, 2026 •

edited by rustbot

Loading

RalfJung Aug 16, 2026 •

edited by rustbot

Loading

RalfJung Aug 16, 2026 •

edited by rustbot

Loading

RalfJung Aug 16, 2026 •

edited by rustbot

Loading