Skip to content

fix 404 url in src/doc/rustdoc.md - #160088

Closed
cuishuang wants to merge 1 commit into
rust-lang:mainfrom
cuishuang:fix_404_url
Closed

fix 404 url in src/doc/rustdoc.md#160088
cuishuang wants to merge 1 commit into
rust-lang:mainfrom
cuishuang:fix_404_url

Conversation

@cuishuang

@cuishuang cuishuang commented Jul 28, 2026

Copy link
Copy Markdown
Contributor

fix 404 url in src/doc/rustdoc.md

The previous link will lead to a 404 page.

image

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. labels Jul 28, 2026
@rustbot

rustbot commented Jul 28, 2026

Copy link
Copy Markdown
Collaborator

r? @GuillaumeGomez

rustbot has assigned @GuillaumeGomez.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: docs
  • docs expanded to GuillaumeGomez, ehuss
  • Random selection from GuillaumeGomez, ehuss

@GuillaumeGomez

Copy link
Copy Markdown
Member

Thanks!

@bors r+ rollup

@rust-bors

rust-bors Bot commented Jul 28, 2026

Copy link
Copy Markdown
Contributor

📌 Commit f98529c has been approved by GuillaumeGomez

It is now in the queue for this repository.

@rust-bors rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 28, 2026
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Jul 28, 2026
…Gomez

fix 404 url in src/doc/rustdoc.md

fix 404 url in src/doc/rustdoc.md

The previous link will lead to a 404 page.

<img width="2744" height="1238" alt="image" src="https://github.com/user-attachments/assets/b1c81c69-2181-4cb1-8a06-83e7b32ebd6c" />
rust-bors Bot pushed a commit that referenced this pull request Jul 28, 2026
…uwer

Rollup of 14 pull requests

Successful merges:

 - #159990 (Many "predicate"-to-"clause" renamings)
 - #159665 (Replace most `Ty::new_fn_def` calls with `type_of` queries directly)
 - #159687 (rustdoc: Set tracing max_level_info when debug-logging is false)
 - #160065 (Distinguish the dep-graph index space from the live node count)
 - #159978 (run intrinsic-test by default on x86_64-gnu)
 - #160008 (Avoid stale closure recovery state across statements)
 - #160027 (Add regression test for #132767)
 - #160030 (Update `browser-ui-test` version to `0.25.0`)
 - #160046 (Improve consistency of attribute error messages (part 2))
 - #160056 (Fix associated function suggestion for generic ADTs)
 - #160069 (Update Rust crate tracing-subscriber to v0.3.23 [SECURITY])
 - #160071 (sanitize_standard_fds: clarify macos comment)
 - #160076 (use unstable features when updating dependencies)
 - #160088 (fix 404 url in src/doc/rustdoc.md)
@rust-log-analyzer

Copy link
Copy Markdown
Collaborator

The job aarch64-gnu-llvm-21-2 failed! Check out the build log: (web) (plain enhanced) (plain)

Click to see the possible cause of the failure (guessed by this bot)
##[endgroup]
[TIMING:end] tool::ToolBuild { build_compiler: Compiler { stage: 0, host: aarch64-unknown-linux-gnu, forced_compiler: false }, target: aarch64-unknown-linux-gnu, tool: "linkchecker", path: "src/tools/linkchecker", mode: ToolBootstrap, source_type: InTree, extra_features: [], allow_features: "", cargo_args: [], artifact_kind: Binary } -- 0.134
[TIMING:end] tool::Linkchecker { compiler: Compiler { stage: 0, host: aarch64-unknown-linux-gnu, forced_compiler: false }, target: aarch64-unknown-linux-gnu } -- 0.000
##[group]Testing stage1 Linkcheck (aarch64-unknown-linux-gnu)
rustdoc.html:32: broken link - `rustdoc/src`
checked links in: 25.0s
number of HTML files scanned: 62478
number of HTML redirects found: 22211
number of links checked: 2983528
number of links ignored due to external: 184531
number of links ignored due to exceptions: 31
number of intra doc links ignored: 9
errors found: 1
found some broken links
NOTE: if you are adding or renaming a markdown file in a mdBook, don't forget to register the page in SUMMARY.md
Command `/checkout/obj/build/aarch64-unknown-linux-gnu/stage1-tools-bin/linkchecker /checkout/obj/build/aarch64-unknown-linux-gnu/doc` failed with exit code 1
Created at: src/bootstrap/src/core/build_steps/tool.rs:1624:23
Executed at: src/bootstrap/src/core/build_steps/test.rs:202:77

Command has failed. Rerun with -v to see more details.
Bootstrap failed while executing `--stage 2 test --skip tidy --skip library/stdarch/crates/intrinsic-test --skip src/tools/rust-analyzer --skip tests --skip library --skip tidyselftest`
Currently active steps:
test::Linkcheck { host: aarch64-unknown-linux-gnu } at src/bootstrap/src/core/build_steps/test.rs:139
Build completed unsuccessfully in 0:32:01
  local time: Tue Jul 28 16:35:02 UTC 2026

@JonathanBrouwer

Copy link
Copy Markdown
Member

💔 I suspect this PR failed tests as part of a rollup
@bors r-

After fixing the problem, consider running a try job for the failed job before re-approving.

Link to failure: #160089 (comment)

@rust-bors rust-bors Bot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jul 28, 2026
@rust-bors

rust-bors Bot commented Jul 28, 2026

Copy link
Copy Markdown
Contributor

This pull request was unapproved.

This PR was contained in a rollup (#160089), which was unapproved.

View changes since this unapproval

@cuishuang

Copy link
Copy Markdown
Contributor Author

This pull request was unapproved.

This PR was contained in a rollup (#160089), which was unapproved.

View changes since this unapproval

@JonathanBrouwer Thank you for your reply. If there's anything need I to do, please feel free to let me know.

@JonathanBrouwer

Copy link
Copy Markdown
Member

@cuishuang To preserve CI resources Rusts ci is split into two parts: PR ci and full ci (also referred to as autojobs). Your PR failed on a job in full ci, which you'll need to fix before this is reapproved :3. The failure is linked in my comment

@cuishuang

Copy link
Copy Markdown
Contributor Author

@cuishuang To preserve CI resources Rusts ci is split into two parts: PR ci and full ci (also referred to as autojobs). Your PR failed on a job in full ci, which you'll need to fix before this is reapproved :3. The failure is linked in my comment

Thanks for the explanation. I misunderstood the role of src/doc/rustdoc.md: it is rendered as rustdoc.html, so relative links need to point into the generated documentation tree. rustdoc/index.html is correct there, while rustdoc/src only exists in the repository source tree, which caused the linkchecker failure.

I'll close this PR. Sorry for the noise, and thanks for pointing me in the right direction!

@cuishuang cuishuang closed this Aug 28, 2026
@rustbot rustbot removed the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Aug 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants