Skip to content

x86_64-win: Enable f128 on LLVM 23+ - #158918

Open
tgross35 wants to merge 1 commit into
rust-lang:mainfrom
tgross35:win64-f128-updates
Open

x86_64-win: Enable f128 on LLVM 23+#158918
tgross35 wants to merge 1 commit into
rust-lang:mainfrom
tgross35:win64-f128-updates

Conversation

@tgross35

@tgross35 tgross35 commented Jul 7, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

LLVM23 includes the ABI fix to make f128 work 1. That version isn't
yet stable, but at least the type will start getting picked up in
top-of-tree CI.

While addressing this, also update the comment regarding f16.

@tgross35

tgross35 commented Jul 7, 2026

Copy link
Copy Markdown
Contributor Author

@bors try jobs=x86_64-msvc*,x86_64-mingw*

@rust-bors

This comment has been minimized.

Sign in to view
rust-bors Bot pushed a commit that referenced this pull request Jul 7, 2026
@bors
Auto merge of #158918 - tgross35:win64-f128-updates, r=<try>
a7adc0d 
x86_64-win: Return f128 on the stack, matching LLVM


try-job: x86_64-msvc*
try-job: x86_64-mingw*
@rustbot rustbot added A-LLVM Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues. S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jul 7, 2026
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rust-bors

rust-bors Bot commented Jul 7, 2026

Copy link
Copy Markdown
Contributor

💔 Test for a7adc0d failed: CI. Failed jobs:

@rust-bors

This comment has been minimized.

Sign in to view
@tgross35
x86_64-win: Enable f128 on LLVM 23+
fd86d6d 
LLVM23 includes the ABI fix to make f128 work [1]. That version isn't
yet stable, but at least the type will start getting picked up in
top-of-tree CI.

While addressing this, also update the comment regarding f16.

[1]: llvm/llvm-project@aa47e59
@tgross35
tgross35 force-pushed the win64-f128-updates branch from 23a594c to fd86d6d Compare August 13, 2026 00:48
@tgross35

tgross35 commented Aug 13, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

First commit was pulled in via the LLVM PR, 2c089a6

@tgross35 tgross35 changed the title x86_64-win: Return f128 on the stack, matching LLVM x86_64-win: Enable f128 on LLVM 23+ Aug 13, 2026
@tgross35

tgross35 commented Aug 13, 2026

Copy link
Copy Markdown
Contributor Author

@bors try jobs=x86_64-msvc*,x86_64-mingw*

@rust-bors

This comment has been minimized.

Sign in to view
rust-bors Bot pushed a commit that referenced this pull request Aug 13, 2026
@bors
Auto merge of #158918 - tgross35:win64-f128-updates, r=<try>
f3cff50 
x86_64-win: Enable f128 on LLVM 23+


try-job: x86_64-msvc*
try-job: x86_64-mingw*
@tgross35

tgross35 commented Aug 13, 2026

Copy link
Copy Markdown
Contributor Author

r? @folkertdev

@tgross35
tgross35 marked this pull request as ready for review August 13, 2026 02:14
@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 13, 2026
@rustbot

rustbot commented Aug 13, 2026

Copy link
Copy Markdown
Collaborator

r? @mejrs

rustbot has assigned @mejrs.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: compiler
  • compiler expanded to 75 candidates
  • Random selection from 15 candidates

@rustbot rustbot removed the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Aug 13, 2026
@tgross35

tgross35 commented Aug 13, 2026

Copy link
Copy Markdown
Contributor Author

r? @folkertdev

@rustbot

rustbot commented Aug 13, 2026

Copy link
Copy Markdown
Collaborator

Requested reviewer is already assigned to this pull request.

Please choose another assignee.

@rust-log-analyzer

rust-log-analyzer commented Aug 13, 2026

Copy link
Copy Markdown
Collaborator

The job x86_64-msvc-1 failed! Check out the build log: (web) (plain enhanced) (plain)

Click to see the possible cause of the failure (guessed by this bot)

@rust-bors rust-bors Bot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 13, 2026
@rust-bors

rust-bors Bot commented Aug 13, 2026

Copy link
Copy Markdown
Contributor

💔 Test for f3cff50 failed: CI. Failed jobs:

@tgross35

tgross35 commented Aug 13, 2026

Copy link
Copy Markdown
Contributor Author

The hosted runner lost communication with the server. Anything in your workflow that terminates the runner process, starves it for CPU/Memory, or blocks its network access can cause this error.

@bors try jobs=x86_64-mingw-2,x86_64-msvc-1

@rust-bors

This comment has been minimized.

Sign in to view
rust-bors Bot pushed a commit that referenced this pull request Aug 13, 2026
@bors
Auto merge of #158918 - tgross35:win64-f128-updates, r=<try>
1756fa4 
x86_64-win: Enable f128 on LLVM 23+


try-job: x86_64-mingw-2
try-job: x86_64-msvc-1
@rust-bors

rust-bors Bot commented Aug 13, 2026

Copy link
Copy Markdown
Contributor

☀️ Try build successful (CI)
Build commit: 1756fa4 (1756fa4a0d4d08288d62c4ef278682aedd54dbd9)
Base parent: 52d0866 (52d08664805c8deb47b7e86999d7f8647b424a15)

@tgross35
tgross35 requested a review from folkertdev August 13, 2026 07:19
@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Aug 13, 2026
@folkertdev

folkertdev commented Aug 13, 2026

Copy link
Copy Markdown
Contributor

@bors r+

@rust-bors

rust-bors Bot commented Aug 13, 2026

Copy link
Copy Markdown
Contributor

📌 Commit fd86d6d has been approved by folkertdev

It is now in the queue for this repository.

@rust-bors rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 13, 2026
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Aug 13, 2026
@JonathanBrouwer
Rollup merge of rust-lang#158918 - tgross35:win64-f128-updates, r=fol…
dd09da0 
…kertdev

x86_64-win: Enable f128 on LLVM 23+

LLVM23 includes the ABI fix to make f128 work [1]. That version isn't
yet stable, but at least the type will start getting picked up in
top-of-tree CI.

While addressing this, also update the comment regarding f16.

[1]: llvm/llvm-project@aa47e59
@JonathanBrouwer JonathanBrouwer mentioned this pull request Aug 13, 2026
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@folkertdev folkertdev Awaiting requested review from folkertdev

At least 1 approving review is required to merge this pull request.

Assignees

@folkertdev folkertdev

Labels

A-LLVM Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@tgross35 @rust-log-analyzer @rustbot @folkertdev @mejrs