Repository navigation
Tracking issue for better testing for dist artifacts #136822
Description
This is a tracking issue for improving the testing for dist artifacts (including but not limited to, dist compilers and dist components like rustc-src).
As of the time of writing, much of dist components are not really tested or exercised in a basic way (modulo tests through opt-dist, but not all dist artifacts go through opt-dist).
Activity
jieyouxu commentedon Feb 10, 2025
I know that
x86_64-unknown-linux-gnuandaarch64-unknown-linux-gnudist artifacts do receive some degree of testing due to post-PGO opt-dist tests.It's the apple and windows dist artifacts that I don't know if are tested at all.
ChrisDenton commentedon Feb 10, 2025
Yes I think not testing CI dist artefacts is the default rather than the exception.
[-]`i686-pc-windows-gnu` dist artifacts are not tested[/-][+]dist artifacts are generally not tested[/+]Noratrieb commentedon Feb 10, 2025
If we call the issue like that, no one will bother to ever fix it of course. But this does actually affect more than just
i686-pc-windows-gnuso someone might actually care.jieyouxu commentedon Feb 12, 2025
Zulip discussion: https://rust-lang.zulipchat.com/#narrow/channel/242791-t-infra/topic/Testing.20dist.20artifacts.3F
Noratrieb commentedon Feb 23, 2025
A bootstrap PR broke tools completely after dist, #137469. Smoke tests would have prevented that as well.
jieyouxu commentedon Mar 11, 2025
See also #138306. That is a case where the
rustc-srcdist component broke because we tried to use workspace lint table of the rust-lang/rust root manifest, which is not shipped as part of this dist component, so compiler sources no longer build on their own. I didn't catch this nor did the PR author because we would've needed to inspect therustc-srcdist component...[-]dist artifacts are generally not tested[/-][+]Tracking issue for better testing for dist artifacts[/+]rustc-devdist component on CI #138646