Rustup - #5296
Merged
Merged
Conversation
…kang Refactor the `#[allow(dead_code)]` propagation for impl items of traits Extracted from rust-lang/rust#157885. This PR does the refactor and corrects the previous implementation. The following will fail currently ([play](https://play.rust-lang.org/?version=nightly&mode=debug&edition=2024&gist=3279902b2d2e6b0fe75c5af565b1cddd)): ```rust #![deny(dead_code)] #![deny(unfulfilled_lint_expectations)] #[allow(dead_code)] pub trait Tr { fn foo(&self); } struct Foo; impl Tr for Foo { fn foo(&self) { bar(); } } #[expect(dead_code)] fn bar() {} fn main() {} ``` After this PR, we could handle the `#[allow(dead_code)]` propagation correctly, and should get perf improvement.
Consolidate LLVM skip in check builds in bootstrap Before it was distributed amongst two places, which made it harder to follow the logic, and the `RUST_CHECK` logic was also applied for *anything* being built, even though it is only relevant for rustc itself. This PR centralizes the handling, and also enables it for `doc` builds. So `./x doc compiler` now doesn't require building LLVM 🎉 r? jieyouxu
This updates the rust-version file to 17fd5b8a37b6667b6cc137f3cc35f09759768a3b.
Pull recent changes from https://github.com/rust-lang/rust via Josh. Upstream ref: rust-lang/rust@17fd5b8 Filtered ref: rust-lang/miri@e69d469 Upstream diff: rust-lang/rust@d0f2ef5...17fd5b8 This merge was created using https://github.com/rust-lang/josh-sync.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.