Add miri.toml config file for ./miri script - #5289
Open
RalfJung wants to merge 4 commits into
Open
Conversation
RalfJung
commented
Aug 26, 2026
| let name = name.as_deref().or(config.toolchain.name.as_deref()).unwrap_or("miri"); | ||
| // Compute rustup-toolchain-install-master flags for additional components. | ||
| let component_flags = | ||
| config.toolchain.components.iter().flat_map(|component| ["-c", component]); |
Member
Author
There was a problem hiding this comment.
I absolutely love how I don't even have to store these in a Vec, I can just directly pass the iterator to cmd!. :D
RalfJung
force-pushed
the
miri.toml
branch
2 times, most recently
from
August 26, 2026 21:56
78fe373 to
1415dcd
Compare
RalfJung
force-pushed
the
miri.toml
branch
2 times, most recently
from
August 26, 2026 22:16
f2f76ab to
1395cc3
Compare
Member
I'll probably just set-and-forget. Looks good to me. |
This comment has been minimized.
This comment has been minimized.
Collaborator
|
This PR was rebased onto a different master commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As discussed in #4700, this adds a
miri.tomlconfig file for our./miribuild script. The supported config flags in this PR are:The old
.auto*files are still supported: they are used as fallback if there is nomiri.tomlfile.@rust-lang/miri what do you think? Any feedback on the names for stuff in the config file?