Skip to content

Remove sparc64 roundtrip skips - #5383

Merged
tgross35 merged 1 commit into
rust-lang:mainfrom
LusterSourav:sparc64
Aug 9, 2026
Merged

Remove sparc64 roundtrip skips#5383
tgross35 merged 1 commit into
rust-lang:mainfrom
LusterSourav:sparc64

Conversation

@LusterSourav

@LusterSourav LusterSourav commented Aug 7, 2026

Copy link
Copy Markdown
Contributor

Fixes issues #1427 and #1558.

The 17 test skips on sparc64 for rustc were due to bugs in the sparc64 ABI implementation. These bugs have been fixed in http://github.com/rust-lang/rust/pull/142680, which was merged on February 12, 2026. Since the libc CI runs every night, these skips are no longer relevant. Removing them will allow the tier2 sparc64 job to properly verify the tests.

We've kept other test skips related to FAM type, max_align_t on i686 and ppc64, s390x mcontext_t, and freebsd gregset because those are separate problems.

Close #1427
Close #1558.

@rustbot

rustbot commented Aug 8, 2026

Copy link
Copy Markdown
Collaborator

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

@tgross35 tgross35 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since the libc CI runs every night, these skips are no longer relevant.

We do run it once per day but that's just for cache purposes - what you mean here is that we run tests against nightly :)

But LGTM

View changes since this review

@tgross35
tgross35 added this pull request to the merge queue Aug 9, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Aug 9, 2026
@tgross35
tgross35 added this pull request to the merge queue Aug 9, 2026
@tgross35 tgross35 added the stable-nominated This PR should be considered for cherry-pick to libc's stable release branch label Aug 9, 2026
Merged via the queue into rust-lang:main with commit 7f28e6e Aug 9, 2026
57 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stable-nominated This PR should be considered for cherry-pick to libc's stable release branch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ip_mreqn roundtrip test fails for mips64 and sparc64 A couple of APIs fail roundtrip tests on CI

3 participants