Declare MSRV as 1.87, add tests for it#1277
Merged
Merged
Conversation
DanielEScherzer
force-pushed
the
msrv-1.87
branch
3 times, most recently
from
9594c74 to
1485647
Compare
Contributor
Author
but lets just not use the locked version |
DanielEScherzer
force-pushed
the
msrv-1.87
branch
from
1485647 to
842ffb1
Compare
DanielEScherzer
force-pushed
the
msrv-1.87
branch
from
842ffb1 to
34faa43
Compare
weihanglo
approved these changes
Jun 15, 2026
Comment on lines
+40
to
+48
| - name: Cargo test (locked) | ||
| if: ${{ matrix.build != 'MSRV' }} | ||
| run: cargo test --locked | ||
| - name: Remove lock file | ||
| if: ${{ matrix.build == 'MSRV' }} | ||
| run: rm Cargo.lock | ||
| - name: Cargo test (unlocked) | ||
| if: ${{ matrix.build == 'MSRV' }} | ||
| run: cargo test |
Member
There was a problem hiding this comment.
Can we generate the lockfile for 1.87, so that is likely be compatible with other versions of toolchains?
Member
There was a problem hiding this comment.
Oh you addressed this in a later commit. Never mind.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1276