fix meta-spec 2, add dynamic_config, remove generated MANIFEST entries

[Grinnz]

META.json/META.yml are added by make dist and EUMM complains if they're there since they arent in the repo.

Updated META_MERGE contents to meta-spec 2 so they get added to META properly.

and added dynamic_config 0 since Makefile.PL does not do dynamic prereqs.

[Grinnz]

Also removed upper bound on setting LICENSE since setting it in resources doesn't set the upper-level key in META.

[rurban]

No, I needed the and $EUMM_VER le '6.46' LICENSE check. EUMM complains when the license is already specified via META.

Also the MANIFEST needs to stay:

tar tfz Net-Ping-2.66.tar.gz|grep META
Net-Ping-2.66/META.json
Net-Ping-2.66/META.yml

dynamic_config is also not specified on all EUMM versions, so needs to be version guarded.
I never used this, and I have static configs everywhere. Need to learn about that

[Grinnz]

EUMM complains when the license is already specified via META.

It does not complain for me, and this would be useless, since license in resources added by META_MERGE and top-level license are two unrelated fields. (top-level field says the type of license, resources license has a link to the license text.) Currently your metadata does not specify a license type as you can see on metacpan.

Also the MANIFEST needs to stay:

These entries are added by make dist as I said, when it generates the files it also adds them to the generated MANIFEST. EUMM complains that the files do not exist if you add them yourself.

dynamic_config is also not specified on all EUMM versions, so needs to be version guarded.

This is within META_MERGE so is already guarded by that.

[Grinnz]

I never used this, and I have static configs everywhere. Need to learn about that

You can read about it here: https://metacpan.org/pod/CPAN::Meta::Spec#dynamic_config

Important note is that you should only use it in META_MERGE when also setting meta-spec 2, because meta-spec 1.4 dynamic_config meant something different.

[rurban]

Ok, I see. But I insist on the LICENSE guard, since it fails for me.

[Grinnz]

I added it back, but this is what it does to the generated metadata:

diff -ur Net-Ping-2.66-withlicense/META.json Net-Ping-2.66/META.json
--- Net-Ping-2.66-withlicense/META.json 2018-03-08 14:06:56.487134719 -0500
+++ Net-Ping-2.66/META.json     2018-03-08 14:08:19.584309116 -0500
@@ -11,7 +11,7 @@
    "dynamic_config" : 0,
    "generated_by" : "ExtUtils::MakeMaker version 7.32, CPAN::Meta::Converter version 2.150010",
    "license" : [
-      "perl_5"
+      "unknown"
    ],
    "meta-spec" : {
       "url" : "http://search.cpan.org/perldoc?CPAN::Meta::Spec",

[rurban]

That's not good. I'll investigate the logic.