Repository navigation
avm1: Migrate flash.geom.Matrix to pure ActionScript - #24831
Merged
Merged
Conversation
Member
An LLM model / agent cannot legally hold authorship and we cannot contact it. If for some reason you want to mention what model you were using to produce the commit, please don't use the |
kjarosh
added
A-avm1
Lord-McSweeney
approved these changes
Oct 6, 2026
kjarosh
approved these changes
Oct 6, 2026
Give the generic helpers in avm1/rectangle the same definitions as in avm1/matrix and avm1/point, so they can later be de-duplicated. The tracingMethod helper now prints call arguments and tracingNumber takes a label, so the expected output is re-recorded from Flash Player.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Similar to #24736 and #24743, but for
flash.geom.Matrix.Testing
Converted the
avm1/matrixtest to Rascal and expanded it.Also extracted a shared
test_utils.asfile to de-duplicate common helper functions between different tests.Checklist