fix(server): support JACK_MANAGEMENT_KEY - #72
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
JACK_MANAGEMENT_KEYor the legacyMANAGEMENT_KEYon the serverJACK_MANAGEMENT_KEYwhen both variables are definedVerification
bun test apps packages— 422 passedmise run lintmise run typecheckdocker compose configfor both example Compose filesgit diff --checkGreptile Summary
This PR adds backend support for the preferred
JACK_MANAGEMENT_KEYenvironment variable while retaining the legacy alias.JACK_MANAGEMENT_KEYwhen both key names are supplied and adds precedence/compatibility tests.Confidence Score: 5/5
The PR appears safe to merge with no concrete changed-code defects identified.
The prefixed key is mapped into the existing nonempty validated management-key field, the legacy name remains supported, precedence is intentional and tested, and the deployment examples provide the same required value to both services.
Reviews (1): Last reviewed commit: "fix(server): support prefixed management..." | Re-trigger Greptile