Fix multiplier passed as isg in create_stream call#11
Draft
shivanayak wants to merge 1 commit into
Draft
Conversation
The multiplier argument was positionally landing in the isg parameter, so streams always used the default multiplier of 1. Co-Authored-By: Claude noreply@anthropic.com
shivanayak
force-pushed
the
fix/multiqueue-create-stream-multiplier
branch
from
35bed74 to
8ba13e9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
multiplierwas passed positionally tocreate_stream(), landing in theisgparameter slot — so the actual multiplier was always the default1multiplieras a keyword argument to fix the bugTest plan
gen_trafficwith--multiplier > 1and verify traffic rate scales accordinglyCo-Authored-By: Claude noreply@anthropic.com