Conversation
Contributor
|
Yeah seems completely unrelated to Code coverage reporting still seems to work about as well as before, although I notice and filed an issue related to code coverage unrelated to your change since it seems the coverage reporting for PRs is hard to access. |
datho7561
approved these changes
Oct 2, 2026
Contributor
|
Thanks, Noritaka! |
datho7561
force-pushed
the
remove-unused-mocha-lcov-reporter
branch
from
October 2, 2026 21:08
01b385f to
f856b80
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Removes the unused
mocha-lcov-reporterdev dependency frompackage.jsonandpackage-lock.json.Git history indicates that this dependency has been unused since it was added in c7d1d7e as part of the Coveralls setup. LCOV output was generated by
nycfrom the start, and no configuration referencingmocha-lcov-reporterwas found.What issues does this PR fix or reference?
No associated issue.
Is it tested? How?
Verified with
mocha-lcov-reporterabsent fromnode_modules:npm run build— passed, including lint and compilation.npm run coveralls -- --reporter dot— 1,360 tests passed, 5 pending, and no failures.coverage/lcov.infoandcoverage/lcov-report/index.htmlwere generated successfully.