Repository navigation
Incorrect types in declaration file #177
Description
Warning: Github issues are not an official support channel for Recurly. If you have an urgent request we suggest you contact us through an official channel: support@recurly.com or https://recurly.zendesk.com
Describe the bug
Types definitions are incorrect:
- all fields are optional and nullable
- some types are not strongly typed (ex: Plan.state -> string instead of an enum)
short example from the declaration file:
export declare class Plan {
/**
* Plan ID
*/
id?: string | null; -> should be id: string;
That's a big problem because in that state those type definitions cannot be used... Are you aware of that issue ? And do you plan to fix it ?
Thanks !
Activity
wcauchois commentedon May 17, 2021
I want to chime in here that it's very inconvenient that every type is nullable (e.g.
idon invoice - link). Could the developers please fix this to reflect what fields are actually nullable? This leads to code with either tons of redundant nullability checks, or null assertions.Silverwolf90 commentedon May 23, 2022
Well I'm here a year later to complain about the same thing. It's a terrible developer experience.
dmmulroy commentedon Jun 11, 2022
I'm also here to see if there is any plans to address this?
wlechowicz commentedon May 9, 2025
5 years later, types are still terrible. Nullable
ids? Nullable strings where API specifies enums? Shame.