Add auto-correction, indentation config, and multi-violation support to multiline_call_arguments#6745
Open
GandaLF2006 wants to merge 6 commits into
Conversation
GandaLF2006
force-pushed
the
gandalf2006/multiline_call_arguments/correctable
branch
2 times, most recently
from
b183a6a to
78a2da1
Compare
Contributor
Author
|
@SimplyDanny Let's add correctable for The CI failure on oss_scan is not related to this PR — it's a danger bot failing to post a comment due to the repository's interaction limits (422 - Interactions on this repository have been restricted to prior contributors only) |
SimplyDanny
reviewed
Jun 6, 2026
| /// | ||
| /// - `tab`: Use tab character for indentation | ||
| /// - `spaces(count:)`: Use the specified number of spaces | ||
| enum IndentationStyle: Hashable, Sendable { |
Collaborator
There was a problem hiding this comment.
There is already a IndentationStyle that can be configured in configuration files and is supposed to apply globally. Can we use it in this rule as well?
Contributor
Author
There was a problem hiding this comment.
Good point — done. The rule-local IndentationStyle has been replaced by the
shared IndentationStyle type from SwiftLintCore, which is the same type
used by the global indentation configuration. This required two changes:
- Moving the type to
SwiftLintCore(the lowest common dependency) and adding
AcceptableByConfigurationElementconformance +indentationStringproperty
so both the rule andConfiguration.indentationcan use it. - Aligning the string value to
"tabs"(matching the global config format)
instead of the previous"tab".
GandaLF2006
force-pushed
the
gandalf2006/multiline_call_arguments/correctable
branch
from
f16bd4c to
8b5b043
Compare
Generated by 🚫 Danger |
GandaLF2006
force-pushed
the
gandalf2006/multiline_call_arguments/correctable
branch
from
3c09c9b to
c2b5aa8
Compare
GandaLF2006
force-pushed
the
gandalf2006/multiline_call_arguments/correctable
branch
from
c2b5aa8 to
9510ef7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Enhances the
multiline_call_argumentsopt-in rule with auto-correction, a newindentationconfiguration option, and multi-violation detection in a single pass.Auto-correction (
--fix))moves to its own line at the call's base indent\n+ indent in the appropriate range--fixpassindentationconfigurationindentation(integer ≥ 1 for spaces, or the string"tab"; default:4)0and negative values are invalid and cause a configuration errorMulti-violation support
duplicateArgumentStartLineViolationandnewlineAfterCommaViolationreturned at the first match, requiring repeated--fixpasses for calls with multiple same-line argument pairsreasonedViolationsreturns[ReasonedRuleViolation])Documentation
RuleDescription.descriptioninto concisedescription(what) + structuredrationale(why/how) with markdown sections