refactor: use renderable guard for marks - #1094
Conversation
|
@QDyanbing is attempting to deploy a commit to the afc163's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Team Run ID: 📒 Files selected for processing (2)
Included review availability: Your plan provides up to 8 included reviews per hour; 7 remain after this review. WalkthroughChangesMark label 过滤
Estimated code review effort: 2 (Simple) | ~10 minutes Merge Risk: ⚪ Minimal · up to Slider mark labels now use React-renderability checks, preserving valid numeric content such as 0 and NaN while retaining empty-content handling. The dependency requirement is updated for the helper, and no current merge-blocking risk is identified. Suggested reviewers: Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Full details: Docstring CoverageExplanation No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 1 files. (1 skipped: 1 unsupported.) ✨ Finishing Touches 💡 1🛠️ Fix failing CI checks 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1094 +/- ##
=======================================
Coverage 98.66% 98.66%
=======================================
Files 15 15
Lines 751 751
Branches 224 233 +9
=======================================
Hits 741 741
Misses 10 10 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
说明
isReactRenderable统一判断 mark label 是否需要渲染0、NaN等有效 React 内容@rc-component/util的最低版本提升到首次提供该 helper 的^1.13.0验证
npm run tscnpm test -- --runInBandgit diff --check关联 ant-design/ant-design#59193
Summary by CodeRabbit