fix(dialog): only set aria-describedby when a Description is rendered#4013
Open
momomuchu wants to merge 1 commit into
Open
fix(dialog): only set aria-describedby when a Description is rendered#4013momomuchu wants to merge 1 commit into
momomuchu wants to merge 1 commit into
Conversation
Fixes a dangling ARIA reference (WCAG 4.1.2) where Dialog.Content always pointed aria-describedby at a generated id even when no Dialog.Description was mounted. Dialog.Description now registers its presence with context so Content only references the id when there is an element for it to describe. Fixes radix-ui#3007
🦋 Changeset detectedLatest commit: 3fcf5f0 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dialog.Contentalways setsaria-describedbyto a generated id, even when noDialog.Descriptionis rendered, leaving a dangling ARIA reference (WCAG 4.1.2) (#3007).Dialog.Descriptionnow registers its presence through context, andDialogContentImplonly setsaria-describedbywhen a Description is actually mounted. An explicit user-providedaria-describedbystill works and the missing-description dev warning is unchanged. Alert Dialog inherits the fix since it delegates toDialog.Description.Added a
dialog.test.tsxcase asserting noaria-describedbywithout a Description. It fails without the fix and passes with it. All dialog and alert-dialog tests pass, typecheck and lint clean.Closes #3007