fix(popover): close popover when trigger scrolls out of view#3982
Open
ArkadiNazarian wants to merge 2 commits into
Open
fix(popover): close popover when trigger scrolls out of view#3982ArkadiNazarian wants to merge 2 commits into
ArkadiNazarian wants to merge 2 commits into
Conversation
🦋 Changeset detectedLatest commit: 7a9c3ff The changes in this PR will be included in the next version bump. This PR includes changesets to release 10 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes: #3688
Problem
When a Popover is opened inside a scrollable container and the user scrolls, the Popover content overflows its parent container and remains visible even after the trigger element has been scrolled out of view.
Solution
This PR adds logic to automatically close the Popover when its trigger element scrolls out of the visible viewport. This prevents the Popover from appearing detached from its trigger and overflowing the parent container.
Storybook Example
Added a new Storybook story demonstrating the fix:
Story name: Popover / In Scroll Container
Location:
apps/storybook/stories/popover.stories.tsxTests
packages/react/popover/src/popover.test.tsx):Tests hideWhenDetached prop defaults to true
Tests ability to override hideWhenDetached to false
cypress/e2e/Popover.cy.ts):