Repository navigation
ci: automate stable WinGet manifest updates - #189
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The WinGet publisher used a Linux runner for a Windows-only validator, reused the release credential, and sent raw YAML to a Contents API field that requires Base64. The existing checks did not exercise these paths.
Changes
windows-2025, using pinned official Microsoft WinGet client/bootstrap module1.29.380.WINGET_TOKENto the submission step. The normal release pipeline invokes a separate job after GitHub Release and crate publication, with onlycontents: read;RELEASE_TOKENremains dedicated to the version-PR writer.release-dev, and build manifest branches from Microsoft's currentmaster.--validate-onlyand make the real Windows validator a required part ofworkflow-security-gate.Validation
Checked head:
8f1874d7a6dc83f67e2f5b62f539f8961b4859a3.v1.0.26executable, verified its uploaded size, SHA-256 and x64 PE header, then successfully executedwinget validate --manifeston all three generated manifests. No GitHub writes were requested.Publication setup
A separate
WINGET_TOKENis required, with permission to write manifest branches inqqrm/winget-pkgsand open PRs inmicrosoft/winget-pkgs. Do not substituteRELEASE_TOKEN.After merge and credential setup, run Backfill WinGet manifest on
devwith an empty release tag. It selects the latest stable release and checks existing catalog entries and PRs before submission. This automation never merges a PR inmicrosoft/winget-pkgs.