Ensure uninstall_command has all required config.#342
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR fixes an AttributeError during py uninstall by ensuring UninstallCommand defines and initializes the configuration fields that downstream shortcut/alias update logic expects, aligning uninstall behavior with install configuration. It also expands CI coverage by installing additional Python runtimes during post-build validation.
Changes:
- Add
enable_entrypoints/hard_link_entrypointsdefaults toUninstallCommandand copy related settings from theinstallconfig section before executing uninstall. - Update CI pipelines to install additional runtimes (3.5–3.9) during build/release validation runs.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
src/manage/commands.py |
Ensures uninstall command has required config attributes and copies install-related settings to prevent uninstall-time failures during shortcut/alias updates. |
ci/release.yml |
Adds a post-test step to install additional runtimes as part of release pipeline validation. |
.github/workflows/build.yml |
Adds a CI step to install additional runtimes during GitHub Actions build validation. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #283