Repository navigation
fix: preserve user-declared __slots__ on the generated class - #1645
Open
kevindurant735rocket-creator wants to merge 1 commit into
Open
kevindurant735rocket-creator wants to merge 1 commit into
kevindurant735rocket-creator wants to merge 1 commit into
Conversation
attrs previously discarded an explicitly declared __slots__ tuple when building the slots class, so names declared by the user were silently dropped (no attribute, no error). Honor the declared names and de-dup against inherited slots, keeping frozen/pickle behavior intact. Fixes python-attrs#1637
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1637.
attrs previously discarded an explicitly declared
__slots__tuple when building the slots class, so names declared by the user were silently dropped (no attribute, no error). Honor the declared names and de-dup against inherited slots, keeping frozen/pickle behavior intact.Evidence:
tests/test_slots.py: 67 passed (new cases cover mangle / pickle / frozen / de-dup boundaries)Verified on master @ ee66e72.