Repository navigation
Conversation
emadleo13
force-pushed
the
fix-1637-user-defined-slots
branch
from
October 17, 2026 21:47
9e235d9 to
1e0115e
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When an
attrsclass defines__slots__explicitly, the generated slotted class did not preserve those user-defined slots.This change preserves explicitly declared
__slots__while avoiding duplicate slots inherited from base classes.Changes
__slots__when generating the slotted class.__slots__.Tests
Added regression tests covering:
Full test suite: