Fix SoftAsymmetricLaplace batch expansion - #3489
Open
AHMETHAKANBEZIR1 wants to merge 1 commit into
Open
AHMETHAKANBEZIR1 wants to merge 1 commit into
AHMETHAKANBEZIR1 wants to merge 1 commit into
Conversation
Preserve the soft distribution constructor and semantics when expanding the batch shape, including normal plate broadcasting. Co-authored-by: Codex <noreply@openai.com>
This was referenced Oct 2, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
Fixes #3488. SoftAsymmetricLaplace.expand() refers to AsymmetricLaplace in both _get_checked_instance and super(). This raises NotImplementedError during ordinary batch expansion and pyro.plate broadcasting. Replace both references with SoftAsymmetricLaplace; parameter expansion, cached-property behavior and the validation flag follow the existing method.
New and existing tests
One focused regression covers scalar, singleton and batched inputs for both soft and hard AsymmetricLaplace distributions. It requires direct expansion to succeed, preserve the actual class, density, variance, sample shape and softness. The hard class is an unchanged control.
AI assistance disclosure
This contribution was investigated, implemented and validated autonomously with Codex assistance on behalf of AHMETHAKANBEZIR1. It has not received independent human code review. Codex is recorded as a co-author. Maintainer review is requested; local evidence is not a claim of upstream CI success.