Conversation
pyro.plate accepted negative size and subsample_size values without warning, silently producing empty or degenerate subsamples. Raise ValueError for negative values. Fixes pyro-ppl#3407.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3407.
pyro.platesilently accepted negativesizeandsubsample_sizevalues, which can produce empty or degenerate subsamples and give misleading likelihood scaling.Add validation in
SubsampleMessenger._subsamplethat raisesValueErrorfor negativesizeandsubsample_size.Added tests
test_plate_rejects_negative_sizeandtest_plate_rejects_negative_subsample_size.